Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pnpm Symlink support w. @rnx-kit/metro-resolver-symlinks, etc? #125

Open
karlhorky opened this issue Jul 9, 2024 · 1 comment
Open

pnpm Symlink support w. @rnx-kit/metro-resolver-symlinks, etc? #125

karlhorky opened this issue Jul 9, 2024 · 1 comment

Comments

@karlhorky
Copy link

karlhorky commented Jul 9, 2024

Description of the feature

It appears that a community member @Zn4rK has figured out how to use Expo and Expo Router with pnpm symlinks (without node-linker=hoisted in .npmrc):

It would be great to get:

  1. An official example of this from the Expo team
  2. And potentially also make this the official integration of pnpm with Expo (I can create a separate issue in expo/expo or somewhere else)

Motivation

Being able to support pnpm symlinks with the Metro symlink support is more performant than the current pnpm integration using node-linker=hoisted in .npmrc.

Additional context

More context in the related issues:

@lbxa
Copy link

lbxa commented Oct 13, 2024

Awesome idea @karlhorky. Removing node-linker-hoisted makes a notable difference in the long run.

I gotta say it's nice to see pnpm work with turborepo AND expo. Lifesaver, thanks @Zn4rK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants