Skip to content

tests: add test for compilerless deserialization & docs cleanup#13737

Closed
6d6f6d656e746f wants to merge 5 commits into
bytecodealliance:mainfrom
6d6f6d656e746f:feature/compilerless-deserialize-test-and-docs-fixes
Closed

tests: add test for compilerless deserialization & docs cleanup#13737
6d6f6d656e746f wants to merge 5 commits into
bytecodealliance:mainfrom
6d6f6d656e746f:feature/compilerless-deserialize-test-and-docs-fixes

Conversation

@6d6f6d656e746f

Copy link
Copy Markdown

This PR adds a unit test verifying that JIT/AOT precompiled WebAssembly modules can be successfully deserialized, instantiated, and executed in an Engine configured without a compiler (enable_compiler(false)).

As recommended by the contribution guidelines regarding trivial changes, I have also bundled a few separate commits to clean up documentation and fix links:

  • Fixes a typo in cli-options.md where --invoke was written as - invoke.
  • Replaces legacy links to bytecodealliance.github.io/wasmtime/api/ with docs.rs/wasmtime.
  • Defines the missing Config::profiler markdown link reference at the bottom of examples-profiling-perf.md.
  • Removes the empty orphan file docs/examples-rust-wasip2.md.

@6d6f6d656e746f 6d6f6d656e746f requested review from a team as code owners June 25, 2026 23:22
@6d6f6d656e746f 6d6f6d656e746f requested review from fitzgen and pchickey and removed request for a team June 25, 2026 23:22
@github-actions github-actions Bot added the wasmtime:docs Issues related to Wasmtime's documentation label Jun 26, 2026
@pchickey

pchickey commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

I don't feel this meets the bar for a nontrivial contribution. If you want to engage with this community and become a contributor to the project, please speak to us in Zulip as a human, but the functionality this tests is so trivial and core to the purpose of those features that I'm confident that its already covered.

The purpose of our policy is that maintainers like me don't have to spend our limited time and energy on PRs from drive-by extractive engagements. If you can demonstrate you are actually using this software and engaging with our community in an additive way, please do so on our Zulip and only make more PRs if asked to there. Right now this has all the smell of an LLM driven engagement farming from an account with very little history, and I don't want to spend more of my time and energy on it.

@pchickey pchickey closed this Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wasmtime:docs Issues related to Wasmtime's documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants