Skip to content

Conversation

@kr11
Copy link
Collaborator

@kr11 kr11 commented Apr 28, 2025

Pull Request Summary

This branch has successfully compiled MySQL 8.0.42 by:

  1. Implementing the changes mentioned in issue Plugin build failures on MySQL 8.0.42 #9.
  2. Optimizing storage/videx/CMakeLists.txt to address the CURL library dependency.

We now need to determine the most compatible approach:

  1. Update the plugin code to be compatible with both MySQL 8.0.42 and Percona 8.0.34, then merge it into the main branch.
  2. Alternatively, tag this branch for users specifically compiling MySQL 8.0.42.

Related Issues

Resolves: #9

Detailed Description

[Explain your changes in detail, including:

  • What problem does this PR solve?
  • How does your solution work?
  • Any trade-offs or alternative approaches considered?]

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to VIDEX! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Core]: Changes to core engine functionality
  • [Opt]: Changes to VIDEX-Optimizer-Plugin
  • [Stats]: Changes to VIDEX-Statistic-Server
  • [Algo]: Implementation of new algorithms for NDV, cardinality estimation, etc.
  • [Pipe]: Enhancements to the pipeline (e.g., data collection, environment setup)
  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [Test]: Adding or updating tests
  • [Perf]: Performance improvements
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use the most specific prefix or multiple prefixes in order of importance (e.g., [Algorithm][Stats]).

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Changes have been tested on both Plugin-Mode and Standalone-Mode (if applicable)
  • Statistical accuracy has been verified (for algorithm or optimizer changes)
  • No regression in query plan accuracy compared to InnoDB (if applicable)
  • Performance benchmarks conducted (for performance-sensitive changes)

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@kr11 kr11 force-pushed the compatibility/mysql8.0.42 branch from b12d3a0 to 4063c92 Compare April 28, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plugin build failures on MySQL 8.0.42

2 participants