Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in profile index #40

Open
callumrollo opened this issue Nov 15, 2021 · 3 comments
Open

Bug in profile index #40

callumrollo opened this issue Nov 15, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@callumrollo
Copy link
Collaborator

When procesing a large dataset, profile_index is 0 every 20 dives or so for a short time

image

This appears to correspond with profile_direction going to 0 rather than +/- 1
@callumrollo callumrollo added the bug Something isn't working label Nov 15, 2021
@jklymak
Copy link
Member

jklymak commented Nov 15, 2021

I think that is by design? i.e. when it is inflecting?

@callumrollo
Copy link
Collaborator Author

Ah ok. In that case we should update the comment in profile_index. It's currently
"N = inside profile N, N + 0.5 = between profiles N and N + 1"

@callumrollo
Copy link
Collaborator Author

Or make it N + 0.5 when it's inflecting

@callumrollo callumrollo mentioned this issue Dec 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jklymak @callumrollo