-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"caddy add-package", "caddy remove-package" could be idempotent #6548
Labels
Milestone
Comments
mholt
changed the title
caddy add-package and caddy add-package could be idempotent, so that its easy to upgrade and downgrade modules in a large fleet without race conditions causing issues.
caddy add-package and caddy remove-package could be idempotent, so that its easy to upgrade and downgrade modules in a large fleet without race conditions causing issues.
Aug 29, 2024
I guess that makes sense. Want to submit a PR? |
gedw99
changed the title
caddy add-package and caddy remove-package could be idempotent, so that its easy to upgrade and downgrade modules in a large fleet without race conditions causing issues.
"caddy add-package", "caddy remove-package" could be idempotent
Aug 29, 2024
I think we should just stick to idempotency for now. As mentioned in other issues, build automation with these commands isn't really intended (there are better tools for the job like xcaddy). |
Got it . Thanks @mholt for steering me . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For idempotency, it would be useful if
caddy add-package
andcaddy remove-package
could be idempotent.caddy remove-package
, will return "Error: package is not added" if I do it twice.caddy add-package
, will return "Error: package is already added", if I do it twice.This idempotency is a nice thing in any architecture, when managing a fleet and building a fleet, because you can just store the package list somewhere and then do
add-package
without worrying if it was done in the past. Treat them like Cows, not delicate kittens :)what is the best way to handle this ?
The text was updated successfully, but these errors were encountered: