Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log sampling Caddyfile support #6680

Closed
francislavoie opened this issue Nov 7, 2024 · 2 comments · Fixed by #6682
Closed

Log sampling Caddyfile support #6680

francislavoie opened this issue Nov 7, 2024 · 2 comments · Fixed by #6682
Labels
feature ⚙️ New feature or request good first issue 🐤 Good for newcomers

Comments

@francislavoie
Copy link
Member

Our logging stack has sampling support, but it's currently only usable via JSON config. We never wired up Caddyfile config for it.

caddy/logging.go

Line 307 in b285763

Sampling *LogSampling `json:"sampling,omitempty"`

We should add Caddyfile support. This should be easy, it should just be a new option added to the log directive called sampling added in this switch:

caddy/caddyconfig/httpcaddyfile/builtins.go

Line 1000 in b285763

case "format":

And it should take a block of options, i.e. interval, first and thereafter.
@francislavoie francislavoie added feature ⚙️ New feature or request good first issue 🐤 Good for newcomers labels Nov 7, 2024
@nikonhub
Copy link
Contributor

nikonhub commented Nov 7, 2024

Hello. I'd like to work on this one :)

@francislavoie
Copy link
Member Author

Go ahead, PRs welcome.

@nikonhub nikonhub mentioned this issue Nov 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature ⚙️ New feature or request good first issue 🐤 Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

httpcaddyfile: Implement log sampling config nikonhub/caddy
2 participants
@francislavoie @nikonhub