Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable retrocert auth page submit button upon submission #635

Open
kalvinwang opened this issue Nov 2, 2020 · 2 comments
Open

Disable retrocert auth page submit button upon submission #635

kalvinwang opened this issue Nov 2, 2020 · 2 comments

Comments

@kalvinwang
Copy link
Contributor

Currently it's possible to click the retrocert auth page submit button multiple times; if the response is 401 unauthorized (due to incorrect SSN, etc.) then the logs will show multiple 401s which pollutes the logs and makes it look like something is wrong. We should disable the submit button upon submission, until a response is received.

@idealisms
Copy link
Contributor

I know there was some concern earlier about how it's confusing to disable buttons. We could also just not send multiple requests until the first one has returned.

It might also be good to have a timeout on the client side (30s? 60s?) in case the request is hanging for some unknown reason.

@kalvinwang
Copy link
Contributor Author

Good point, we don't need need to visually disable the button. Hm, can we figure out what percentage of client-side requests take more than a couple seconds?...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants