Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version number ignored in Addins\packages.config #36

Open
xclayl opened this issue Aug 30, 2017 · 3 comments
Open

Version number ignored in Addins\packages.config #36

xclayl opened this issue Aug 30, 2017 · 3 comments

Comments

@xclayl
Copy link

xclayl commented Aug 30, 2017

Start with this packages.config file:

<packages>
    <package id="Microsoft.SqlServer.DacFx.x86" version="130.3485.1" />
</packages>

run build.ps1 and it'll download the package.

Update packages.config with the new version:

<packages>
    <package id="Microsoft.SqlServer.DacFx.x86" version="140.3745.1" />
</packages>

and run build.ps1.

The Addins folder incorrectly contains version 130.3485.1.

This scenario plays out when you commit the packages.config folder to source control, but not the packages themselves. When one developer updates packages.config, all the other developers continue to use the old version of the package.

@xclayl
Copy link
Author

xclayl commented Aug 30, 2017

The tools folder contains "packages.config.md5sum". Perhaps something similar can be done here to detect a change to Addins\packages.config.

@gep13
Copy link
Member

gep13 commented Aug 30, 2017

@xclayl the advice going forward is likely to be to NOT use the packages.config files. Rather, define your tools/addins via the pre-processor directive. This gives much greater flexibility (i.e. you can define different sources for different packages), and also will cover things like dependencies, etc.

Follow here:

cake-build/cake#1743

for more information.

@xclayl
Copy link
Author

xclayl commented Aug 30, 2017

Thanks -- looking forward to it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants