Merge pull request #19 from cake-tech/CW-912-cleanup1-mobx

Migrate over to mobx

Author: OmarHatem28

.env

@@ -1,2 +1,2 @@
-MONERO_C_TAG=v0.18.3.4-RC12
+MONERO_C_TAG=v0.18.4.0-RC1
 COIN=monero 

android/.gitignore

@@ -12,3 +12,4 @@ key.properties
 **/*.keystore
 **/*.jks
 **/*.pwd
+app/.cxx

build.yaml

@@ -161,10 +161,6 @@ class MoneroWalletCreation extends WalletCreation {
       }
     }
 
-    print(await walletAddress.value);
-    print(await secretSpendKey.value);
-    print(await secretViewKey.value);
-
     return RestoreFromKeysMoneroWalletCreationMethod(
       L,
       walletPath: coin.getPathForWallet(walletName),

docs/README.md

@@ -84,12 +84,12 @@ class MoneroWallet implements CoinWallet {
         Coin.L.partial_key_images: someImages,
         Coin.L.all_key_images: allImages,
       },
-    ).push(context);
+      currentWallet: this,
+    ).pushReplacement(context);
   }
 
   @override
   Future<void> handleUR(final BuildContext context, final URQRData ur) async {
-    print("handling: ${ur.tag}");
     switch (ur.tag) {
       case "xmr-keyimage" || "xmr-txsigned":
         throw Exception("Unable to handle ${ur.tag}. This is a offline wallet");
@@ -145,10 +145,13 @@ class MoneroWallet implements CoinWallet {
               final error = monero.UnsignedTransaction_errorString(txptr);
               throw CoinException(error);
             }
-            await AnimatedURPage(urqrList: {"signedTx": signedTx}).push(context);
+            await AnimatedURPage(
+              urqrList: {"signedTx": signedTx},
+              currentWallet: this,
+            ).pushReplacement(context);
           },
           cancelCallback: () => {},
-        ).push(context);
+        ).pushReplacement(context);
         save();
       default:
         throw UnimplementedError(Coin.L.error_ur_tag_unsupported(ur.tag));

lib/coins/monero/creation/common.dart

@@ -77,6 +77,12 @@ class MoneroWalletInfo extends CoinWalletInfo {
     }
     Monero.wPtrList.clear();
     final basePath = p.dirname(walletName);
+    if (File(p.join(basePath, newName)).existsSync()) {
+      throw Exception(Coin.L.error_wallet_name_already_exists);
+    }
+    if (File(p.join(basePath, "$newName.keys")).existsSync()) {
+      throw Exception(Coin.L.error_wallet_name_already_exists);
+    }
     File(walletName).copySync(p.join(basePath, newName));
     File("$walletName.keys").copySync(p.join(basePath, "$newName.keys"));
     // Copy and delete later, if anything throws below we end up with copied walled,

lib/coins/monero/wallet.dart

@@ -39,6 +39,7 @@
   "error_ur_tag_unsupported": "Unable to handle {urTag}",
   "error_wallet_doesnt_exist": "Given wallet doesn't exist {walletName}",
   "error_wallet_is_null_no_indication_of_failure": "Wallet creation failed, and status indicated failure but message was empty",
+  "error_wallet_name_already_exists": "Wallet with this name already exists",
   "error_wallet_name_empty": "Wallet name is empty",
   "error_wallet_name_unchanged": "Wallet wasn't renamed because the name is not different",
   "export_key_images": "Export key images",