Improve logging

Author: josbeir

src/Datasource/Log/ElasticLogger.php

@@ -27,9 +27,9 @@
 use Stringable;
 
 /**
- * Adapter to convert logs to QueryLogger readable content
+ * Adapter to convert Elastica logs to QueryLogger readable content
  *
- * Handles the new elasticsearch-php package logging format with PSR-7 requests/responses.
+ * Handles the elasticsearch-php package logging format with PSR-7 requests/responses.
  */
 class ElasticLogger extends AbstractLogger
 {
@@ -43,6 +43,11 @@ class ElasticLogger extends AbstractLogger
      */
     protected Connection $_connection;
 
+    /**
+     * Track previous log to avoid duplicates
+     */
+    protected ?string $_lastLogHash = null;
+
     /**
      * Constructor, set the QueryLogger instance
      *
@@ -95,7 +100,7 @@ public function log(mixed $level, Stringable|string $message, array $context = [
      * them to the cake defined logger instance
      *
      * Elastica log parameters with elasticsearch-php package:
-     * -----------------------------------------------------------
+     * --------------------------------------------------------
      * error:
      *     message: "Elastica Request Failure"
      *     context: [ exception, request, retry ]
@@ -112,9 +117,22 @@ public function log(mixed $level, Stringable|string $message, array $context = [
      */
     protected function _log(string $level, string $message, array $context = []): void
     {
+        // Skip empty contexts to reduce noise
+        if ($context === []) {
+            return;
+        }
+
         $logData = $this->extractLogData($context);
         $logDataJson = json_encode($logData, JSON_PRETTY_PRINT | JSON_UNESCAPED_UNICODE) ?: '{}';
 
+        // Simple duplicate detection
+        $logHash = md5($level . $logDataJson);
+        if ($logHash === $this->_lastLogHash) {
+            return;
+        }
+
+        $this->_lastLogHash = $logHash;
+
         if ($this->hasRequestResponse($context)) {
             $queryMetrics = $this->extractQueryMetrics($context);
 
@@ -141,7 +159,6 @@ protected function _log(string $level, string $message, array $context = []): vo
     protected function extractLogData(array $context): array
     {
         if (!isset($context['request'])) {
-            // Return original context when no request data to extract
             return $context;
         }
 

src/TestSuite/Fixture/DeleteQueryStrategy.php

@@ -76,7 +76,7 @@ public function teardownTest(): void
                     $esIndex->deleteByQuery(new MatchAll());
                 } catch (ClientResponseException $e) {
                     // Ignore version conflicts during test cleanup
-                    // ElasticSearch 9.x is stricter about optimistic concurrency control
+                    // ElasticSearch is stricter about optimistic concurrency control
                     if ($e->getCode() !== 409) {
                         throw $e;
                     }

tests/TestCase/Datasource/ConnectionTest.php

@@ -89,7 +89,7 @@ public function testConstructLogOption(): void
      */
     public function testQueryLoggingWithLog(): void
     {
-        // Create a connection with logging enabled using modern Elastica 9.x config
+        // Create a connection with logging enabled using modern Elastica config
         /** @var Connection $connection */
         $connection = ConnectionManager::get('test');
         $connection->enableQueryLogging();
@@ -108,7 +108,7 @@ public function testQueryLoggingWithLog(): void
     }
 
     /**
-     * Ensure that QueryLogger integration works with Elastica 9.x.
+     * Ensure that QueryLogger integration works with Elastica.
      */
     public function testLoggerQueryLogger(): void
     {