onPress fired even though the element is not a touch responder

[pke]

I had accidently set the onPress handler on my custom component instead of the wrapped Pressable and the handler was still called when my test tried fireEvent.press(element).

Shouldn't that have failed because the onPress was a prop on a non Pressable?

function Item({ onPress, title }) {
  return <View><Text>{title}</Text></View> // Note: onPress is not set, and no Pressable is used, but a view
}

The test:

const pressed = jest.fn()
const { getByText } = render(() => <Item onPress={pressed} title="test"/>)
const item = getByText("test")
fireEvent.press(item)
// Test should fail, but it doesnt
expect(pressed).toHaveBeenCalledTimes(1)

[mdjastrzebski]

I've run the above code using current version of RNTL and it fails as expected

My code:

import * as React from 'react';
import { View, Text } from 'react-native';
import fireEvent from './fireEvent';
import render from './render';

function Item({ onPress, title }) {
  return (
    <View>
      <Text>{title}</Text>
    </View>
  ); // Note: onPress is not set, and no Pressable is used, but a view
}

test('aa', () => {
  const pressed = jest.fn();
  const { getByText } = render(<Item onPress={pressed} title="test" />);
  const item = getByText('test');
  fireEvent.press(item);
  // Test should fail, but it doesnt
  expect(pressed).toHaveBeenCalledTimes(1);
});

Test output:

    expect(jest.fn()).toHaveBeenCalledTimes(expected)

    Expected number of calls: 1
    Received number of calls: 0

      18 |   fireEvent.press(item);
      19 |   // Test should fail, but it doesnt
    > 20 |   expect(pressed).toHaveBeenCalledTimes(1);
         |                   ^
      21 | });
      22 |

      at Object.<anonymous> (aaa.test.js:20:19)

Test Suites: 1 failed, 1 total
Tests:       1 failed, 1 total
Snapshots:   0 total
Time:        0.708 s, estimated 1 s

If you see other behaviour please provide repro repository.

BTW: render(() => <Item onPress={pressed} title="test"/>) should be render(<Item onPress={pressed} title="test"/>), otherwise React Test Renderer displays error:

  console.error
    Warning: Functions are not valid as a React child. This may happen if you return a Component instead of <Component /> from render. Or maybe you meant to call this function rather than return it.

      at printWarning (../node_modules/react-test-renderer/cjs/react-test-renderer.development.js:68:30)
      at error (../node_modules/react-test-renderer/cjs/react-test-renderer.development.js:44:5)
      at warnOnFunctionType (../node_modules/react-test-renderer/cjs/react-test-renderer.development.js:4553:5)
      at reconcileChildFibers (../node_modules/react-test-renderer/cjs/react-test-renderer.development.js:5444:9)
      at reconcileChildren (../node_modules/react-test-renderer/cjs/react-test-renderer.development.js:7991:28)
      at updateHostRoot (../node_modules/react-test-renderer/cjs/react-test-renderer.development.js:8547:5)
      at beginWork (../node_modules/react-test-renderer/cjs/react-test-renderer.development.js:9994:14)

[pke]

Thanks, I will give it another try if I find the code I wanted to test this with again ;)