Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reserved identifier violation #2

Open
elfring opened this issue Oct 8, 2016 · 8 comments
Open

reserved identifier violation #2

elfring opened this issue Oct 8, 2016 · 8 comments

Comments

@elfring
Copy link

elfring commented Oct 8, 2016

I would like to point out that identifiers like "_H_FASTERHTTP_" and "_H_HETAO_IN_" do not fit to the expected naming convention of the C language standard.
Would you like to adjust your selection for unique names?
@calvinwilliams
Copy link
Owner

；）

@elfring
Copy link
Author

elfring commented Oct 9, 2016

How do you think about to avoid that this software depends on undefined behaviour?

@calvinwilliams
Copy link
Owner

I fixed it ! ^______________________^

@elfring
Copy link
Author

elfring commented Oct 9, 2016

Which commit will contain corresponding changes?

@calvinwilliams
Copy link
Owner

Sorry , I commited it just now

UPDATE TO V0.9.1C BETA

@elfring
Copy link
Author

elfring commented Oct 9, 2016

I find that there are still a few update candidates left over.

@calvinwilliams
Copy link
Owner

It's a symbol for nm and grep for find out version directly , I reserved it

@calvinwilliams calvinwilliams reopened this Oct 9, 2016
@elfring
Copy link
Author

elfring commented Oct 9, 2016

Can your kind of "reservation" work also without the usage of misplaced underscores?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elfring @calvinwilliams