Skip to content

Conversation

@astrojuanlu
Copy link
Contributor

@astrojuanlu astrojuanlu commented Oct 21, 2025

Issue

Fix #649

Builds on #663

Solution

Checklist

  • I have added or updated any relevant documentation.
  • I have cleaned any remaining cloud resources from my accounts.

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.93%. Comparing base (e7c1809) to head (8fe3efb).
⚠️ Report is 203 commits behind head on main.

Files with missing lines Patch % Lines
lib/charms/mysql/v0/mysql.py 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #699      +/-   ##
==========================================
- Coverage   66.25%   63.93%   -2.33%     
==========================================
  Files          17       20       +3     
  Lines        3180     4725    +1545     
  Branches      424      773     +349     
==========================================
+ Hits         2107     3021     +914     
- Misses        935     1455     +520     
- Partials      138      249     +111     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@astrojuanlu astrojuanlu changed the title bug : replace event.set_results(success=False) with event.fail() in get-cluster-status (take 2) DPE-7649 Replace event.set_results(success=False) with event.fail() in get-cluster-status (take 2) Oct 21, 2025
@astrojuanlu astrojuanlu marked this pull request as ready for review October 21, 2025 13:07
@astrojuanlu
Copy link
Contributor Author

astrojuanlu commented Oct 21, 2025

Made a small change on top of @arjun11-malik 's original PR. I'd like to request a first round of feedback.

@astrojuanlu astrojuanlu changed the title DPE-7649 Replace event.set_results(success=False) with event.fail() in get-cluster-status (take 2) DPE-7649 Replace event.set_results(success=False) with event.fail() in action get-cluster-status (take 2) Oct 21, 2025
@carlcsaposs-canonical
Copy link
Contributor

test failures appear to be from missing secrets since PR is from fork

@paulomach are you able to add @astrojuanlu to https://github.com/orgs/canonical/teams/data-mysql to give write access to push to a branch on this repo?

@paulomach
Copy link
Contributor

test failures appear to be from missing secrets since PR is from fork

@paulomach are you able to add @astrojuanlu to https://github.com/orgs/canonical/teams/data-mysql to give write access to push to a branch on this repo?

Indeed. I can't but I know a guy

Copy link
Contributor

@paulomach paulomach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I asked for inclusion in the gh team

@astrojuanlu
Copy link
Contributor Author

Pushed to a repo branch, I have to close this PR and request your approval again in #700. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

On action get_cluster_status failure, results are set as if success

5 participants