-
Notifications
You must be signed in to change notification settings - Fork 18
DPE-7649 Replace event.set_results(success=False) with event.fail() in action get-cluster-status (take 2)
#699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DPE-7649 Replace event.set_results(success=False) with event.fail() in action get-cluster-status (take 2)
#699
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #699 +/- ##
==========================================
- Coverage 66.25% 63.93% -2.33%
==========================================
Files 17 20 +3
Lines 3180 4725 +1545
Branches 424 773 +349
==========================================
+ Hits 2107 3021 +914
- Misses 935 1455 +520
- Partials 138 249 +111 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Made a small change on top of @arjun11-malik 's original PR. I'd like to request a first round of feedback. |
event.set_results(success=False) with event.fail() in action get-cluster-status (take 2)
|
test failures appear to be from missing secrets since PR is from fork @paulomach are you able to add @astrojuanlu to https://github.com/orgs/canonical/teams/data-mysql to give write access to push to a branch on this repo? |
Indeed. I can't but I know a guy |
paulomach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I asked for inclusion in the gh team
|
Pushed to a repo branch, I have to close this PR and request your approval again in #700. Thank you! |
Issue
Fix #649
Builds on #663
Solution
Checklist