Skip to content

Commit 0a0486f

Browse files
committed
fix unit fixed setting postgresql version into app_peer_data
1 parent d917d88 commit 0a0486f

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/charm.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1585,7 +1585,9 @@ def _validate_database_version(self):
15851585
peer_db_version = self.app_peer_data.get("database-version")
15861586

15871587
if self.unit.is_leader() and peer_db_version is None:
1588-
self.app_peer_data.update({"database-version": self._patroni.get_postgresql_version()})
1588+
_psql_version = self._patroni.get_postgresql_version()
1589+
if _psql_version is not None:
1590+
self.app_peer_data.update({"database-version": _psql_version})
15891591
return
15901592

15911593
if peer_db_version != self._patroni.get_postgresql_version():

tests/unit/test_charm.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1372,7 +1372,7 @@ def test_on_peer_relation_changed(
13721372
self.harness.update_relation_data(
13731373
self.rel_id,
13741374
self.charm.app.name,
1375-
{"cluster_initialised": "True", "members_ips": '["1.1.1.1"]'},
1375+
{"cluster_initialised": "True", "members_ips": '["1.1.1.1"]', "database_version": "14"},
13761376
)
13771377
self.harness.set_leader()
13781378
_reconfigure_cluster.return_value = False

0 commit comments

Comments
 (0)