feat(app-check): support static debug token on web #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eljass/capacitor-firebase into feat-support-static-debug-token
chore(app-check): adds changeset for the changes
…eljass/capacitor-firebase into feat-support-static-debug-token
|
Sorry for commit message mess. Tried to squash these to single one, but seems to have failed to do so. I think this can be merged with "squash and merge" to remove unnecessary commits from the history. |
|
Thank you. I'm currently working on the update to Capacitor 7. I will soon take a look at your PR. |
robingenz
requested changes
Jan 30, 2025
`debug` option is removed
robingenz
requested changes
Feb 3, 2025
Comment on lines
54
to
55
| String debugTokenString = call.getString("debugToken", ""); | ||
| hasDebugToken = debugTokenString != null && !debugTokenString.isEmpty(); |
There was a problem hiding this comment.
Suggested change
| String debugTokenString = call.getString("debugToken", ""); | |
| hasDebugToken = debugTokenString != null && !debugTokenString.isEmpty(); | |
| String debugTokenString = call.getString("debugToken"); | |
| hasDebugToken = debugTokenString != null; |
There was a problem hiding this comment.
How would you match the empty string then? In web it is seen as falsy, but in this case in Android code debugTokenString != null will return as true if debugToken option is set to "".
...rc/main/java/io/capawesome/capacitorjs/plugins/firebase/appcheck/FirebaseAppCheckPlugin.java
Show resolved
Hide resolved
Co-authored-by: Robin Genz <[email protected]>
…eljass/capacitor-firebase into feat-support-static-debug-token
robingenz
previously approved these changes
Feb 4, 2025
|
@eljass Please fix the failed workflow. |
@capacitor-firebase/analytics
@capacitor-firebase/app
@capacitor-firebase/app-check
@capacitor-firebase/authentication
@capacitor-firebase/crashlytics
@capacitor-firebase/firestore
@capacitor-firebase/functions
@capacitor-firebase/messaging
@capacitor-firebase/performance
@capacitor-firebase/remote-config
@capacitor-firebase/storage
commit: |
|
Thank you! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run changeset).Adds support to include static debug token within web App Check initialization. This can be used with CI and/or during development.
Refers to: #808