Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(barcode-scanning): missing privacy manifest #178

Closed
3 of 7 tasks
akships opened this issue Aug 24, 2024 · 4 comments · Fixed by #179
Closed
3 of 7 tasks

bug(barcode-scanning): missing privacy manifest #178

akships opened this issue Aug 24, 2024 · 4 comments · Fixed by #179
Labels
breaking change Breaking change bug/fix Something isn't working dependencies package: barcode-scanning
Milestone
v7.0.0

Comments

@akships
Copy link

akships commented Aug 24, 2024

Plugin(s)

  • Barcode Scanning
  • Face Detection
  • Face Mesh Detection
  • Selfie Segmentation
  • Translation

Current problem

When I push my app to apple there is always this warning about privacy

privacy-apple

Preferred solution

I think this is due to dependency to MLKIT (which is dependent to an old version of GoogleToolboxForMac) version which is 5.0.0 currently and should be at least 6.0.0 or even 7.0.0.
On those latest versions the privacy issue is fixed.

Is it possible to update podspec to fix this or another solution in mind ?

Alternative options

No response

Additional context

Using current latest version of package 6.1.0

Before submitting
@robingenz
Copy link
Member

According to the changelog, the latest version for GoogleMLKit/BarcodeScanning is 5.0.0. This version is used by the plugin.

@Mercury-Ong
Copy link

Mercury-Ong commented Aug 25, 2024 •
edited
Loading

Hi! I updated the GoogleMLKit/BarcodeScanning to 6.0.0 manually and ran pod update.
These packages were updated, and everything seems to be working fine. (for now)

Installing CapacitorMlkitBarcodeScanning 6.1.0
Installing GoogleMLKit 6.0.0 (was 5.0.0)
Installing GoogleToolboxForMac 4.2.1 (was 2.3.2) 
Installing MLKitBarcodeScanning 5.0.0 (was 4.0.0)
Installing MLKitCommon 11.0.0 (was 10.0.0)
Installing MLKitVision 7.0.0 (was 6.0.0)

The privacy policy was added on version 4.2.0 for GoogleToolboxForMac.

@robingenz robingenz mentioned this issue Aug 26, 2024
Merged
3 tasks
@robingenz
Copy link
Member

robingenz commented Aug 28, 2024 •
edited
Loading

I have created a PR to update the pods: #179. Unfortunately, it contains breaking changes, so I can't merge the PR yet. You can use the pre-release in the meantime:

npm i https://pkg.pr.new/capawesome-team/capacitor-mlkit/@capacitor-mlkit/barcode-scanning@327eae6

@robingenz robingenz added breaking change Breaking change and removed needs: triage labels Aug 28, 2024
@robingenz robingenz added this to the v7.0.0 milestone Aug 28, 2024
@robingenz robingenz changed the title feat: update dependecy to mlkit to solve privacy issue with apple feat: update dependecies to solve privacy issue with Apple Oct 3, 2024
@robingenz robingenz pinned this issue Oct 3, 2024
@robingenz robingenz changed the title feat: update dependecies to solve privacy issue with Apple bug: missing privacy manifest Oct 3, 2024
@robingenz robingenz added bug/fix Something isn't working and removed feature Feature labels Oct 3, 2024
@robingenz robingenz changed the title bug: missing privacy manifest bug(barcode-scanning): missing privacy manifest Oct 3, 2024
@robingenz
Copy link
Member

Closed by #179. Please install the latest version using the next tag:

npm install @capacitor-mlkit/barcode-scanning@next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change Breaking change bug/fix Something isn't working dependencies package: barcode-scanning
Projects
None yet
Milestone
v7.0.0
Development

Successfully merging a pull request may close this issue.

fix!: update GoogleMLKit pods to version 6.0.0 on iOS capawesome-team/capacitor-mlkit
3 participants
@akships @robingenz @Mercury-Ong