Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: startScan is not resolved on iOS #48

Closed
4 of 7 tasks
JanMisker opened this issue Jun 20, 2023 · 2 comments · Fixed by #50
Closed
4 of 7 tasks

bug: startScan is not resolved on iOS #48

JanMisker opened this issue Jun 20, 2023 · 2 comments · Fixed by #50
Assignees
Labels
bug/fix Something isn't working package: barcode-scanning platform: ios iOS platform

Comments

@JanMisker
Copy link
Contributor

Plugin(s)

  • Barcode Scanning
  • Translation

Did you test the latest version?

  • I use the latest version

Platform(s)

  • Android
  • iOS
  • Web

Current behavior

The startScan() method returns a Promise that is never resolved.

Expected behavior

The Promise should resolve.

Reproduction

https://github.com/JanMisker/capacitor-mlkit-plugin-demo

Steps to reproduce

Run the demo app.
I added a console.log("before startScan()") and console.log("after startScan()").
On Android I see both messages logged, but on iOS only the before one.

Other information

No response

Capacitor doctor

💊   Capacitor Doctor  💊 

Latest Dependencies:

  @capacitor/cli: 5.0.5
  @capacitor/core: 5.0.5
  @capacitor/android: 5.0.5
  @capacitor/ios: 5.0.5

Installed Dependencies:

  @capacitor/cli: 5.0.0
  @capacitor/core: 5.0.0
  @capacitor/android: 5.0.0
  @capacitor/ios: 5.0.0

[success] iOS looking great! 👌
[error] Missing <manifest package=""> attribute in app/src/main

Before submitting

  • I understand that incomplete issues (e.g. without reproduction) are closed.
@robingenz
Copy link
Member

Thank you for creating this issue.
Seems like I forgot to call „completion()“ in line

I will fix this as soon as I am home. You can also submit a PR.

@robingenz robingenz self-assigned this Jun 21, 2023
@robingenz robingenz changed the title bug: bug: startScan is not resolved on iOS Jun 21, 2023
@JanMisker
Copy link
Contributor Author

Check, see PR #50

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug/fix Something isn't working package: barcode-scanning platform: ios iOS platform
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants