Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No validation for Custom Transformer Docker Image Name #72

Open
ariefrahmansyah opened this issue Feb 9, 2021 · 0 comments
Open

No validation for Custom Transformer Docker Image Name #72

ariefrahmansyah opened this issue Feb 9, 2021 · 0 comments

Comments

@ariefrahmansyah
Copy link
Contributor

Expected Behavior

Prevent user from submitting invalid custom Docker image name

Current Behavior

There's no validation for the Custom Transformer Docker Image name in the input-form, enabling the user to submit it and continue with the deployment. It leads to error creating inference service.

Steps to reproduce

  1. In the model deployment page, choose Custom Transformer
  2. In the Docker Image name, write an invalid docker name. For example, add a space between the name and tag: my-image-name: my-tag
  3. Click Deploy
  4. The UI will display success, but after waiting, the deployment will be failed with the error message: error creating inference service

Possible Solution

Add validation.

*We may need to check for another validation needed in other input components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant