fix(Form): add Storybook controls - #22852
Open
Subhom1 wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for v3-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v2-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22852 +/- ##
==========================================
- Coverage 89.59% 89.59% -0.01%
==========================================
Files 582 582
Lines 53277 53317 +40
Branches 7259 7309 +50
==========================================
+ Hits 47736 47770 +34
- Misses 5404 5410 +6
Partials 137 137
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20924
Adds operable React Storybook controls for the native properties exposed by
Form. Both the default and AI-label stories now support a custom class name, accessible label, and submit action while preventing Storybook submissions from navigating away.Changelog
New
Changed
Removed
Testing / Reviewing
Use the repository Node version and start React Storybook:
Open
Components/Form.In Default, verify the class-name control updates the form class and the accessible-label control updates the form’s accessible name.
Submit the form and confirm
onSubmitappears in Actions without leaving the story.Open With AI label and repeat the Form checks for both the standard and fluid forms.
Confirm the existing AI-label, disabled, invalid, and warning controls still work.
Run the focused checks:
The Web Components
cds-formelement has no configurable component properties. Its default story therefore has no meaningful controls to add, while its AI-label story already exposes working child-state controls.Test Screenshots
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
Tested for cross-browser consistencyMore details can be found in the [pull request guide](https://github.com/carbon-design-system/carbon/blob/main/docs/guides/reviewing-pull-requests.md).