Skip to content

Conversation

@Divyue30597
Copy link
Contributor

Closes #20986

Active item is not visible during keyboard navigation in filterable multi-select

Changelog

New
Nothing new, just updated the logic.

Changed
Used the parent class method for the navigation and updated the logic

Removed
Removed the repeated logic which was already available in parent class method,

Testing / Reviewing

Upon running yarn test in packages/web-components all the changed lines were covered and no new tests we added.

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@Divyue30597 Divyue30597 requested a review from a team as a code owner November 13, 2025 12:46
@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2025

All contributors have signed the DCO.
Posted by the DCO Assistant Lite bot.

@Divyue30597
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@netlify
Copy link

netlify bot commented Nov 13, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 5abb9f1
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/6932d756ffc4660008658d0d
😎 Deploy Preview https://deploy-preview-21013--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 13, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 5abb9f1
🔍 Latest deploy log https://app.netlify.com/projects/carbon-elements/deploys/6932d756b4a0af000804f361
😎 Deploy Preview https://deploy-preview-21013--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 13, 2025

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 5abb9f1
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/6932d756f19aff000822bba8
😎 Deploy Preview https://deploy-preview-21013--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.60%. Comparing base (6e1243f) to head (5abb9f1).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #21013   +/-   ##
=======================================
  Coverage   92.60%   92.60%           
=======================================
  Files         515      515           
  Lines       38225    38198   -27     
  Branches     5871     5811   -60     
=======================================
- Hits        35399    35375   -24     
+ Misses       2676     2674    -2     
+ Partials      150      149    -1     
Flag Coverage Δ
main-packages 85.61% <ø> (ø)
web-components 96.89% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@maradwan26 maradwan26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing 🚀

…ti-select-item-in-multi-select-web-component
Copy link
Contributor

@Gururajj77 Gururajj77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…ti-select-item-in-multi-select-web-component
@Gururajj77 Gururajj77 added this pull request to the merge queue Dec 8, 2025
Merged via the queue into carbon-design-system:main with commit 9531c69 Dec 8, 2025
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Active item not visible during keyboard navigation in filterable multi-select

4 participants