-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fix(multi select) change for navigating multi select item in multi select web component #21013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
All contributors have signed the DCO. |
|
I have read the DCO document and I hereby sign the DCO. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21013 +/- ##
=======================================
Coverage 92.60% 92.60%
=======================================
Files 515 515
Lines 38225 38198 -27
Branches 5871 5811 -60
=======================================
- Hits 35399 35375 -24
+ Misses 2676 2674 -2
+ Partials 150 149 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
maradwan26
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for contributing 🚀
…ti-select-item-in-multi-select-web-component
Gururajj77
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ti-select-item-in-multi-select-web-component
9531c69
Closes #20986
Active item is not visible during keyboard navigation in filterable multi-select
Changelog
New
Nothing new, just updated the logic.
Changed
Used the parent class method for the navigation and updated the logic
Removed
Removed the repeated logic which was already available in parent class method,
Testing / Reviewing
Upon running
yarn testinpackages/web-componentsall the changed lines were covered and no new tests we added.PR Checklist
As the author of this PR, before marking ready for review, confirm you:
More details can be found in the pull request guide