feat(modal): inline-loading, initial focus, and parity with react #21074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21074 +/- ##
==========================================
- Coverage 92.62% 92.50% -0.12%
==========================================
Files 515 515
Lines 38222 38510 +288
Branches 5861 5826 -35
==========================================
+ Hits 35403 35625 +222
- Misses 2669 2736 +67
+ Partials 150 149 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
maradwan26
requested review from
a team and
sunny-babbar
and removed request for
a team
sunny-babbar
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19706
Closes #20734
Closes #20936
Updated focus management logic/styles, added features, and controls to all stories (in both versions) for Modal.
Changelog
New
cds-modal-bodyhas-scrolling-contentor if the modal-body is scrollableautoAlignactivatedloading-status,loading-description,loading-success-delay, andloading-icon-descriptioninactive, acds-inline-loadingelement will render in the modal-footer with the specified attributes for the description, success delay, etc.cds-modal-on-loadingsuccesswhen the loading-status isfinishedcds-modal-label, providedaria-label, andcds-modal-heading.cds-modal-label>aria-label>cds-modal-headingaria-labelupdatingdata-modal-primary-focuswill take precedence over all of the above casesChanged
cds-icon-buttoninstead of the native button and added the respective styling fixes and tweaksTesting / Reviewing
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
[ ] Wrote passing tests that cover this change