Skip to content

Conversation

@boleg-work
Copy link

Guidance to use DismissibleTag is not correct. Instead it should tell users to put the content as children of the component

Changelog

New

Changed

Removed

Testing / Reviewing

Nothing to do

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@boleg-work boleg-work requested a review from a team as a code owner November 28, 2025 12:58
@github-actions
Copy link
Contributor

Thanks for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text:


I have read the DCO document and I hereby sign the DCO.


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot.

@netlify
Copy link

netlify bot commented Nov 28, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit aea80e0
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/69299c5c5bf28e00084a604c
😎 Deploy Preview https://deploy-preview-21089--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 28, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit aea80e0
🔍 Latest deploy log https://app.netlify.com/projects/carbon-elements/deploys/69299c5c2c867d00085c72f8
😎 Deploy Preview https://deploy-preview-21089--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 28, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit aea80e0
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/69299c5caf58e400086185a5
😎 Deploy Preview https://deploy-preview-21089--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.60%. Comparing base (50b0404) to head (aea80e0).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21089      +/-   ##
==========================================
- Coverage   92.62%   92.60%   -0.03%     
==========================================
  Files         515      515              
  Lines       38222    38222              
  Branches     5805     5861      +56     
==========================================
- Hits        35403    35394       -9     
- Misses       2670     2678       +8     
- Partials      149      150       +1     
Flag Coverage Δ
main-packages 85.61% <ø> (ø)
web-components 96.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants