-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix(Tag): Update Guidance for title prop #21089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21089 +/- ##
==========================================
- Coverage 92.62% 92.60% -0.03%
==========================================
Files 515 515
Lines 38222 38222
Branches 5805 5861 +56
==========================================
- Hits 35403 35394 -9
- Misses 2670 2678 +8
- Partials 149 150 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Guidance to use DismissibleTag is not correct. Instead it should tell users to put the content as children of the component
Changelog
New
Changed
Removed
Testing / Reviewing
Nothing to do
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
More details can be found in the pull request guide