fix: modify show condition for labelText and helperText
#21094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21094 +/- ##
=======================================
Coverage 92.60% 92.60%
=======================================
Files 515 515
Lines 38222 38215 -7
Branches 5833 5798 -35
=======================================
- Hits 35394 35389 -5
+ Misses 2678 2677 -1
+ Partials 150 149 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
adamalston
reviewed
Nov 30, 2025
| const checkboxGroupInstanceId = useId(); | ||
|
|
||
| const helperId = !helperText | ||
| const hasHelper = helperText !== null && helperText !== undefined; |
Contributor
There was a problem hiding this comment.
This suggestion applies here and elsewhere:
Suggested change
| const hasHelper = helperText !== null && helperText !== undefined; | |
| const hasHelper = helperText !== null && typeof helperText !== 'undefined'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21093
Falsy check to render
labelTextandhelperTextprevents considering 0 (number) which is a valid input. One solution is to use explicit checks fornullandundefined.Changelog
Changed
Update
labelTextandhelperTextshow conditions from falsy tonullandundefinedchecksTesting / Reviewing
Can be verified by setting the value of
helperTextorlabelTextto 0 (number) in storybook.PR Checklist
As the author of this PR, before marking ready for review, confirm you:
- [ ] Updated documentation and storybook examples- [ ] Wrote passing tests that cover this change- [ ] Tested for cross-browser consistencyMore details can be found in the pull request guide