fix: DatePicker in Modal requires two clicks to open calendar #21109
+23
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21109 +/- ##
==========================================
- Coverage 92.60% 92.59% -0.02%
==========================================
Files 515 515
Lines 38225 38234 +9
Branches 5863 5839 -24
==========================================
+ Hits 35397 35401 +4
- Misses 2678 2683 +5
Partials 150 150
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
adamalston
reviewed
Dec 3, 2025
Comment on lines
+668
to
+682
| // Auto-detect if DatePicker is in a modal and use appendTo for proper positioning | ||
| let effectiveAppendTo = appendTo; | ||
| if (!effectiveAppendTo && start) { | ||
| // Check if the input is inside a modal | ||
| const modalElement = start.closest(`.${prefix}--modal`); | ||
| if (modalElement) { | ||
| // Find the modal container to append the calendar to | ||
| const modalContainer = modalElement.querySelector( | ||
| `.${prefix}--modal-container` | ||
| ); | ||
| if (modalContainer) { | ||
| effectiveAppendTo = modalContainer as HTMLElement; | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
I have a few concerns:
- This change appears to target only modals. Are you certain the issue is limited to modals?
- This functionality relies on class selectors. Is there a more robust way to target modals than using class names? I have the same concern regarding the changes in
Modal.tsx.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #21092
Fix: Auto-detect modals and append calendar to modal container + prevent Modal's auto-scroll from interfering with DatePicker positioning.
Result: Calendar opens correctly on first click in scrollable modals.