feat(DataTableSkeleton): add size prop for consistent row sizing #21111
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21111 +/- ##
==========================================
+ Coverage 92.62% 96.87% +4.24%
==========================================
Files 515 158 -357
Lines 38225 23711 -14514
Branches 5861 951 -4910
==========================================
- Hits 35406 22970 -12436
+ Misses 2670 731 -1939
+ Partials 149 10 -139
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
adamalston
left a comment
adamalston
left a comment
There was a problem hiding this comment.
Can you update the API snapshot?
| it('should respect the size prop', () => { | ||
| render(<DataTableSkeleton size="xs" />); | ||
|
|
||
| expect(screen.getByRole('table')).toHaveClass( | ||
| `${prefix}--data-table--xs` | ||
| ); | ||
| }); |
There was a problem hiding this comment.
I suggest also including a check for the prop's default value.
| showToolbar?: boolean; | ||
|
|
||
|
|
||
| size?: DataTableSize; |
There was a problem hiding this comment.
Has this code been formatted?
| size?: DataTableSize; | |
| /* | |
| * Changes the row height of table. | |
| */ | |
| size?: DataTableSize; |
| showToolbar: PropTypes.bool, | ||
|
|
||
|
|
||
| size: PropTypes.oneOf(['xs', 'sm', 'md', 'lg', 'xl']), |
There was a problem hiding this comment.
| size: PropTypes.oneOf(['xs', 'sm', 'md', 'lg', 'xl']), | |
| /* | |
| * Changes the row height of table. | |
| */ | |
| size: PropTypes.oneOf(['xs', 'sm', 'md', 'lg', 'xl']), |
|
@naaa760 Snapshot tests are failing due to mismatches. Run |
3 participants
Closes: #21096
sizeprop toDataTableSkeletonto matchDataTablerow sizing (xs, sm, md, lg, xl) for visual consistency between loading and data states.Changelog
New
sizeprop toDataTableSkeletonwith test coverage