-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat(stories): add theme control to all component stories #21125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(stories): add theme control to all component stories #21125
Conversation
|
All contributors have signed the DCO. |
4175355 to
c9d0ebf
Compare
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
c9d0ebf to
82d383c
Compare
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
recheck |
Signed-off-by: baadhira <[email protected]>
82d383c to
b548597
Compare
|
custom-pr-sign-comment: I have read the DCO document and I hereby sign the DCO. |
|
I have read the DCO document and I hereby sign the DCO. |
|
recheck |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @baadhira, the theme switcher is already built into Storybook. Is this PR meant to address something else? Also, the theme controls added in this PR don't work for me.
|

Closes #20958
Adds the theme control to all component story files for consistent visual testing across themes.
Changelog
New
{{new thing}}Changed
Removed
{{removed thing}}Testing / Reviewing
For each component story file modified (e.g., ContentSwitcher, Tooltip, TreeView, etc.), verify that the 'theme' control is present and functional in the Storybook Controls tab. Switching the theme should visually update the component (where applicable).
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
Wrote passing tests that cover this changeAddressed any impact on accessibility (a11y)Tested for cross-browser consistencyMore details can be found in the pull request guide