Skip to content

Conversation

@baadhira
Copy link

@baadhira baadhira commented Dec 4, 2025

Closes #20958

Adds the theme control to all component story files for consistent visual testing across themes.

Changelog

New

{{new thing}}

Changed

  • Adds the 'theme' argType and default 'g10' arg to all component story files to enable theme switching in Storybook.

Removed

{{removed thing}}

Testing / Reviewing

For each component story file modified (e.g., ContentSwitcher, Tooltip, TreeView, etc.), verify that the 'theme' control is present and functional in the Storybook Controls tab. Switching the theme should visually update the component (where applicable).

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@baadhira baadhira requested a review from a team as a code owner December 4, 2025 10:00
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

All contributors have signed the DCO.
Posted by the DCO Assistant Lite bot.

@baadhira baadhira force-pushed the fix/20958-add-theme-args branch from 4175355 to c9d0ebf Compare December 4, 2025 10:06
@netlify
Copy link

netlify bot commented Dec 4, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4175355
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/69315bb78a62f8000858367f
😎 Deploy Preview https://deploy-preview-21125--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@baadhira baadhira force-pushed the fix/20958-add-theme-args branch from c9d0ebf to 82d383c Compare December 4, 2025 10:08
@netlify
Copy link

netlify bot commented Dec 4, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit c9d0ebf
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/69315d1e37677f0008668d8e
😎 Deploy Preview https://deploy-preview-21125--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 4, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 4175355
🔍 Latest deploy log https://app.netlify.com/projects/carbon-elements/deploys/69315bb73ea1170008644b31
😎 Deploy Preview https://deploy-preview-21125--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@baadhira
Copy link
Author

baadhira commented Dec 4, 2025

recheck

@baadhira baadhira force-pushed the fix/20958-add-theme-args branch from 82d383c to b548597 Compare December 4, 2025 10:17
@baadhira
Copy link
Author

baadhira commented Dec 4, 2025

custom-pr-sign-comment: I have read the DCO document and I hereby sign the DCO.

@baadhira
Copy link
Author

baadhira commented Dec 4, 2025

I have read the DCO document and I hereby sign the DCO.

@baadhira
Copy link
Author

baadhira commented Dec 4, 2025

recheck

@netlify
Copy link

netlify bot commented Dec 4, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit b548597
🔍 Latest deploy log https://app.netlify.com/projects/carbon-elements/deploys/69315fcbbd7c150008854353
😎 Deploy Preview https://deploy-preview-21125--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 4, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b548597
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/69315fcb97c0390008bf5fbd
😎 Deploy Preview https://deploy-preview-21125--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 4, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit b548597
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/69315fcb97c0390008bf5fc1
😎 Deploy Preview https://deploy-preview-21125--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kennylam
Copy link
Member

kennylam commented Dec 4, 2025

Hi @baadhira, the theme switcher is already built into Storybook. Is this PR meant to address something else? Also, the theme controls added in this PR don't work for me.

image

@maradwan26
Copy link
Contributor

Hi @baadhira, the issue #20958 is for adding controls to the Theme stories, not adding theme controls to all stories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Theme]: add controls args to every story

3 participants