Test/qa improvements for v2.0.0 #658
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move test_tokens_expose_policy_id from test_token_registry.py to test_account_endpoints.py as it validates API contract (policyId always present for native assets) rather than token registry enrichment. The test was incorrectly passing when token registry was misconfigured because policyId is populated from blockchain data, not registry metadata. Changes: - Add TestNativeAssetMetadata class to test_account_endpoints.py - Remove TestPolicyIdMetadata class from test_token_registry.py - Enhanced validation to check all native assets, not just configured tokens - Added policyId format validation (56 hex chars)
- Fix script path from test_construction_api.py to test_golden_examples.py - Remove exit 0 that masked golden example test failures - Add explicit failure if API never starts in wait loop - Always post PR comment, even when deployment fails - Check all test suites (smoke, behavioral, golden) before reporting pass/fail
linconvidal
force-pushed
the
test/qa-improvements-for-v2.0.0
branch
from
7303881 to
91104e9
Compare
linconvidal
force-pushed
the
test/qa-improvements-for-v2.0.0
branch
from
91104e9 to
41e3725
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.