Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint v9 support #127

Open
json-derulo opened this issue Apr 17, 2024 · 12 comments
Open

ESLint v9 support #127

json-derulo opened this issue Apr 17, 2024 · 12 comments

Comments

@json-derulo
Copy link

ESLint v9 has been released recently. This plugin has a peer dependency to ESLint ^8.0.0 and causes peer dependency conflicts with ESLint v9.

@Servonius
Copy link

Also ESLint v9 requires the new flat config which this plugin doesn't support yet.

@json-derulo
Copy link
Author

json-derulo commented May 7, 2024

I got the plugin working in flat config format using ESLint v8, with the following config:

import rxjs from 'eslint-plugin-rxjs';

export default [
  {
    files: ['**/*.ts'],
    plugins: { rxjs },
    rules: { ...rxjs.configs.recommended.rules },
  },
];

For configuring TypeScript ESLint in flat config, see their docs.

@rylorin
Copy link

rylorin commented May 11, 2024

It didn't work for me, I had to do the following changes to my flat config file:

import { fixupPluginRules } from "@eslint/compat";
import eslint from "@eslint/js";
import prettier from "eslint-plugin-prettier/recommended";
import rxjs from "eslint-plugin-rxjs";
import tseslint from "typescript-eslint";

export default tseslint.config(
  eslint.configs.recommended,
  ...tseslint.configs.recommended,
  prettier,
  {
    ...
    plugins: { rxjs: fixupPluginRules(rxjs) },
    rules: {
      ...
      "rxjs/no-async-subscribe": "warn",
      "rxjs/no-ignored-observable": "warn",
      "rxjs/no-ignored-subscription": "warn",
      "rxjs/no-unbound-methods": "warn",
      "rxjs/throw-error": "warn",
    },
  },
);

@dubzzz
Copy link

dubzzz commented Jun 3, 2024

I started to investigate the issue (I'm not related to the project), I think we should get rid-off the dependency called @typescript-eslint/experimental-utils in favor of its official version called @typescript-eslint/utils.

I did a first PR to patch eslint-etc. Once merged and rolled out I can open a similar one on eslint-plugin-rxjs to do the same (and maybe others).

@Sebi11
Copy link

Sebi11 commented Aug 6, 2024

Hello there!
Any chances to see this plugin upgraded to support ESLint 9 in the next few weeks?

@reduckted
Copy link

Support for ESLint v8 ends in two months, so it would be great to get this resolved soon.

@fast-facts
Copy link

Can this now be considered abandonware?

@reduckted
Copy link

ReactiveX/rxjs#7492

@rbirkgit
Copy link

We get this error when updating to ESLint 9.

Error: You have attempted to use a lint rule which requires the full TypeScript type-checker to be available, but you do not have `parserOptions.project` configured to point at your project tsconfig.json files in the relevant TypeScript file "overrides" block of your project ESLint config `src/.eslintrc.json`

We use typed rules and have parserOptions.project set properly. Commenting out rxjs/recommended usage, all linting work again.

@AbakumovAlexandr
Copy link

Look like it's really dead. Will have to remove it from our projects.

@JasonWeinzierl
Copy link

I've started a fork of this project named eslint-plugin-rxjs-x (named following the pattern set by eslint-plugin-import-x) that supports ESLint v9 flat config. It's still in prerelease versions, but feedback/attention is welcome. I intend to review any active issues/PRs in this repository and fix accordingly before releasing v1.0.0. All things going well, I also intend to fork the rxjs-angular rules too.

@DaveMBush
Copy link

I have a port done and just posted https://www.npmjs.com/package/@smarttools/eslint-plugin-rxjs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests