Skip to content

Conversation

@gutmensch
Copy link

What this PR does / why we need it:

The computation for max. length of annotations (256KB) is flawed at the moment as it looks at the length of single values in the map and not the complete map size (which is the actual limitation).

Which issue(s) this PR fixes:

Fixes #48

Does this PR introduce a user-facing change?

NONE

fix: use correct length calculation for original annotation limits

Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated (none exist as of now it seems)
  • Relevant docs in this repo added or updated (bugfix)
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:


    * also use upstream validation function, fixes carvel-dev#48
@carvel-bot carvel-bot added this to Carvel Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Unable to deploy large CRD due to annotation max size limit (262144 characters)

1 participant