-
Notifications
You must be signed in to change notification settings - Fork 123
Strip kustomize-style name hash suffix #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
criztovyl
wants to merge
53
commits into
carvel-dev:develop
Choose a base branch
from
criztovyl:criztovyl/strip-name-hash-suffix
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 50 commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
0e66161
Podman build
criztovyl 1289a91
Refactor podman script to run tests and other scripts
criztovyl 7768d60
Add script shortcuts to podman scripts
criztovyl 5eadc82
Demonstrate nameHashSuffix strip
criztovyl 3376aff
Podman interactive
criztovyl 12c3862
Move suffix-strip flag to change set type
criztovyl 0099750
Add note about SYS_PTRACE
criztovyl 9b32450
Add test against suffix-stripping unsupported resources
criztovyl eed12ec
Add note about disabled check
criztovyl 5b4255c
Fix ChangeSetWithVersionedRs tests
criztovyl a396c46
Add StripNameHashSuffix to config
criztovyl 795bee4
podman histfile
criztovyl a728a67
adjust test to match (new) expectations
criztovyl 8d94e34
Move version checks and version updates
criztovyl 44c51d9
Implement ignoring name-hash-suffix in diff
criztovyl 1f8d0bc
Fix striping suffix from unrelated resources
criztovyl da8749a
podman e2e
criztovyl f3d8e74
gofmt changes
criztovyl 4815452
golint changes
criztovyl 25e6c49
Add files for e2e
criztovyl 8730f13
more e2e resources
criztovyl faf26d7
Delete old name-hash-suffixed resources
criztovyl cd782ec
Mark method private
criztovyl 9391cef
Delete name-hash-suffix CMs based on change
criztovyl 66cc9ea
Add E2E test for name-hash-suffix stripping
criztovyl 9e6a6f1
Kustomize resources README
criztovyl 6b435dc
Fix persisting podman interactive history
criztovyl 8e1c533
Add copyright header
criztovyl a8fd0eb
Test only operation and diff count
criztovyl 9807418
Make name-hash-suffix-strip resource check configurable
criztovyl 72253b1
Lint fixes
criztovyl 0a9194e
Merge remote-tracking branch 'upstream/develop' into criztovyl/strip-…
criztovyl dfd2ccb
Fixes after module rename
criztovyl 3081bd5
Fix test resources after config changed
criztovyl d837a40
Allow to call gen.sh from any directory
criztovyl 9cb989a
Fix comparing diff test
criztovyl be2c3f2
gofmt
criztovyl c8b1e26
Drop old suffix strip implementation
criztovyl cb5da9e
Skip testing unimplemented functionality for now
criztovyl 2bf6a39
instantiate VersionedResource as such
criztovyl f485fcb
Turn VersionedResource into an interface
criztovyl 5c555a0
Reimplement suffix strip
criztovyl 121cb03
Reimplement deleting old has-suffixed resources
criztovyl e22da5b
Make dedicated method for converting []VersionedResource
criztovyl f5333ab
Remove naked return
criztovyl e5cfb41
Keep logic within one method
criztovyl be8bf30
Remove disabled assert
criztovyl ba249a7
enabling suffix strip by matcher presence
criztovyl 4f51583
Drop suffix-strip enable flag
criztovyl aaca097
Fix test
criztovyl 76991f6
replace left-over naked return
criztovyl 8f7848a
Streamline suffix strip config
criztovyl 40fa319
Convert to tests to table tests
criztovyl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| .bash_history | ||
| .dlv |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| cd $(dirname ${BASH_SOURCE[0]}) | ||
|
|
||
| ./podman.sh build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| cd $(dirname ${BASH_SOURCE[0]}) | ||
|
|
||
| action=$1 | ||
|
|
||
| if [ "$action" ]; then | ||
| [ -x "$action.sh" ] && action=hack/$action.sh | ||
| else | ||
| histfile=.bash_history | ||
| [ -f $histfile ] || >$histfile | ||
|
|
||
| interactive="-it -v $PWD/$histfile:/root/$histfile" | ||
|
|
||
| dlv_conf=.dlv | ||
| [ -d $dlv_conf ] || mkdir $dlv_conf | ||
|
|
||
| interactive="$interactive -v $PWD/$dlv_conf:/root/.config/dlv" | ||
| fi | ||
|
|
||
| # SYS_PTRACE for dlv | ||
| # host network for minikube | ||
| podman run --rm \ | ||
| -v gopath:/go \ | ||
| -v gobuild:/root/.cache/go-build \ | ||
| -v $HOME/.kube:/root/.kube \ | ||
| -v $HOME/.minikube:$HOME/.minikube \ | ||
| -v $(realpath $PWD/..):/mnt -w /mnt \ | ||
| $interactive \ | ||
| --cap-add SYS_PTRACE \ | ||
| --network host \ | ||
| docker.io/golang $action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| cd $(dirname ${BASH_SOURCE[0]}) | ||
|
|
||
| ./podman.sh test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.