Skip to content

Commit 7041b64

Browse files
committed
Add missing calls to file.Close()
1 parent 6bb8401 commit 7041b64

File tree

5 files changed

+7
-1
lines changed

5 files changed

+7
-1
lines changed

adapters/repos/db/lsmkv/segment.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ func newSegment(path string, logger logrus.FieldLogger, metrics *Metrics,
6969
if err != nil {
7070
return nil, errors.Wrap(err, "open file")
7171
}
72+
defer file.Close()
7273

7374
file_info, err := file.Stat()
7475
if err != nil {

adapters/repos/db/vector/hnsw/commit_log_combiner.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,11 +150,13 @@ func (c *CommitLogCombiner) mergeFiles(outName, first, second string) error {
150150
if err != nil {
151151
return errors.Wrapf(err, "open first source file %q", first)
152152
}
153+
defer source1.Close()
153154

154155
source2, err := os.Open(second)
155156
if err != nil {
156157
return errors.Wrapf(err, "open second source file %q", second)
157158
}
159+
defer source2.Close()
158160

159161
_, err = io.Copy(out, source1)
160162
if err != nil {

adapters/repos/db/vector/hnsw/condensor.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ func (c *MemoryCondensor) Do(fileName string) error {
3434
if err != nil {
3535
return errors.Wrap(err, "open commit log to be condensed")
3636
}
37+
defer fd.Close()
3738
fdBuf := bufio.NewReaderSize(fd, 256*1024)
3839

3940
res, _, err := NewDeserializer(c.logger).Do(fdBuf, nil, true)

adapters/repos/db/vector/hnsw/condensor_mmap.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ func (c *MmapCondensor) Do(fileName string) error {
3232
if err != nil {
3333
return errors.Wrap(err, "open commit log to be condensed")
3434
}
35+
defer fd.Close()
3536

3637
index, err := c.analyze(fd)
3738
if err != nil {

deprecations/gen.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ func main() {
3636

3737
fd, err := os.Open("deprecations.yml")
3838
fatal(err)
39+
defer fd.Close()
3940

4041
var deprecations struct {
4142
// yaml tags not working on the go-swagger model, so we need to do the
@@ -150,7 +151,7 @@ func ptString(in string) *string {
150151
151152
var ByID = map[string]models.Deprecation{
152153
{{- range .Deprecations }}
153-
{{ printf "%q" .ID }}: {
154+
{{ printf "%q" .ID }}: {
154155
ID: {{ printf "%q" .ID }},
155156
Locations: []string{
156157
{{- range $index, $element := .Locations }}

0 commit comments

Comments
 (0)