chore: add more explicit close for client

evan-forbes · renaynay · commit 6151289e5b0d · 2025-11-07T14:15:25.000-05:00
diff --git a/nodebuilder/tests/helpers_test.go b/nodebuilder/tests/helpers_test.go
@@ -26,8 +26,9 @@ func getAdminClient(ctx context.Context, nd *nodebuilder.Node, t *testing.T) *cl
 	jwt, err := authtoken.NewSignedJWT(signer, []auth.Permission{"public", "read", "write", "admin"}, time.Minute)
 	require.NoError(t, err)
 
-	client, err := client.NewClient(ctx, listenAddr, jwt)
+	client, err := client.NewClient(context.WithoutCancel(ctx), listenAddr, jwt)
 	require.NoError(t, err)
+	t.Cleanup(client.Close)
 
 	return client
 }

Original file line number	Diff line number	Diff line change
`@@ -26,8 +26,9 @@ func getAdminClient(ctx context.Context, nd nodebuilder.Node, t testing.T) *cl`
`26`	`26`	`jwt, err := authtoken.NewSignedJWT(signer, []auth.Permission{"public", "read", "write", "admin"}, time.Minute)`
`27`	`27`	`require.NoError(t, err)`
`28`	`28`
`29`		`- client, err := client.NewClient(ctx, listenAddr, jwt)`
	`29`	`+ client, err := client.NewClient(context.WithoutCancel(ctx), listenAddr, jwt)`
`30`	`30`	`require.NoError(t, err)`
	`31`	`+ t.Cleanup(client.Close)`
`31`	`32`
`32`	`33`	`return client`
`33`	`34`	`}`