You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 23, 2020. It is now read-only.
Currently, we wrap every request with a with-timing call based on the request path, so that we can capture per-slice metrics. However, this has a nasty side effect of also recording metrics for any invalid requests.
We should limit the with-timing calls to only valid, non-400 requests
The text was updated successfully, but these errors were encountered:
the problem here is with the current location of the metrics call. Because the request hasn't yet completed, it doesn't have access to status information. Consequently, this will need to be decoupled from the current per-request logging, or else that information will somehow need to be made available to that function
Currently, we wrap every request with a
with-timing
call based on the request path, so that we can capture per-slice metrics. However, this has a nasty side effect of also recording metrics for any invalid requests.We should limit the with-timing calls to only valid, non-400 requests
The text was updated successfully, but these errors were encountered: