-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Session and Session_iba template #907
Comments
@eleanorreem I would like to contribute on this issue please assign me this issue |
Hey @anmol-fzr thank you for your interest! |
@kyleecodes Hi, I am a student of Technical University of Kosice (Slovakia) and i would like to contribute on this issue as part of a task i was given on one of my subjects (i can provide details about this task in dm/pm). Can u assign me this issue if its still available? |
Thank you @MarosBaran you have been assigned this issue! Support Chayn's mission? ⭐ Please star this repo to help us find more contributors like you! |
Hi @kyleecodes , im already working on this Issue, ive added the SessionVideo/SessionHeader components, extracted the logic for session completion, but now i have 1 question. In StoryBlokSessionPage and StoryBlokSessionIbaPage, there's a different logic for liveChatAccess, in StoryBlokSessionPage it takes into account the liveCourseAccess as well, but it doesnt in StoryBlokSessionIbaPage. Now my question is if thats intended or that it should be fixed to so that both pages share the same logic. I provide screenshots of mentioned code, thank you for your answer. |
Pinging @eleanorreem ! |
Hey @MarosBaran thanks for checking in on this |
Overview
We created a duplicate but slightly different template for our IBA course. There is now a large amount of shared loginc between the regular session template and the session_iba template.
The IBA session page can be found in
pages/courses/image-based-abuse/[sessionSlug].tsx
and the regular session page can be found inpages/courses/[slug]/[sessionSlug].tsx
This ticket is to pull out duplicated logic / code between the two pages into either separate components or functions that can then be shared by the two pages.
Action Items
Here are some suggestions for possible refactors. These are suggestions and you may take a different route:
callStartSession
can move into this componentuseEffect
to open transcript modal can also be moved to this componentTesting
It may make sense to split this ticket out into separate PRs as there could be a lot of changes.
Resources/Instructions
The text was updated successfully, but these errors were encountered: