Skip to content

Commit 41b2dc1

Browse files
committed
correct coding standard
1 parent b8d3b12 commit 41b2dc1

6 files changed

+31
-30
lines changed

accordion_menus.module

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
*/
77

88
/**
9-
* implement hook_theme().
9+
* Implements hook_theme().
1010
*/
1111
function accordion_menus_theme($existing, $type, $theme, $path) {
1212
return [

css/accordion_menus.css

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
.accordion_menus-block-content h2 {
2-
display:none;
3-
}
2+
display: none;
3+
}

js/accordion_menus.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
(function($) {
2-
$(document).ready(function(){
3-
$('.accordion_menus_block_container').accordion({header: "h2.accordion-title", autoHeight: false});
1+
( function($) {
2+
$(document).ready( function() {
3+
$('.accordion_menus_block_container').accordion({header: 'h2.accordion-title', autoHeight: false});
44
});
5-
})(jQuery);
5+
})(jQuery);

src/Form/AccordionMenusConfigForm.php

+11-8
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,19 @@
1010
*/
1111
class AccordionMenusConfigForm extends ConfigFormBase {
1212

13-
/** @var string Config settings */
13+
/**
14+
* @var string Config settings
15+
*/
1416
const SETTINGS = 'accordion_menus.settings';
1517

16-
/**
18+
/**
1719
* {@inheritdoc}
1820
*/
1921
public function getFormId() {
2022
return 'accordion_menus_config_form';
2123
}
2224

23-
/**
25+
/**
2426
* {@inheritdoc}
2527
*/
2628
protected function getEditableConfigNames() {
@@ -29,7 +31,7 @@ protected function getEditableConfigNames() {
2931
];
3032
}
3133

32-
/**
34+
/**
3335
* {@inheritdoc}
3436
*/
3537
public function buildForm(array $form, FormStateInterface $form_state) {
@@ -47,19 +49,20 @@ public function buildForm(array $form, FormStateInterface $form_state) {
4749
return parent::buildForm($form, $form_state);
4850
}
4951

50-
/**
52+
/**
5153
* {@inheritdoc}
5254
*/
5355
public function submitForm(array &$form, FormStateInterface $form_state) {
54-
// Retrieve the configuration and Set the submitted configuration setting
56+
// Retrieve the configuration and Set the submitted configuration setting.
5557
$this->configFactory->getEditable(static::SETTINGS)
5658
->set('accordion_menus', $form_state->getValue('accordion_menus'))
5759
->save();
5860

5961
parent::submitForm($form, $form_state);
6062

61-
// Clear cache is needed to effect this value on block derivetive plugin system.
62-
// See @src/Plugin/Derivative/AccordionMenusBlock
63+
// Clear cache is needed to effect this value on block derivetive plugin
64+
// system. See @src/Plugin/Derivative/AccordionMenusBlock.
6365
drupal_flush_all_caches();
6466
}
67+
6568
}

src/Plugin/Block/AccordionMenusBlock.php

+11-8
Original file line numberDiff line numberDiff line change
@@ -30,20 +30,20 @@ public function build() {
3030
$parameters->setMinDepth(0)->onlyEnabledLinks();
3131

3232
$tree = $menu_tree->load($menu_name, $parameters);
33-
$manipulators = array(
34-
array('callable' => 'menu.default_tree_manipulators:checkAccess'),
35-
array('callable' => 'menu.default_tree_manipulators:generateIndexAndSort'),
36-
);
33+
$manipulators = [
34+
['callable' => 'menu.default_tree_manipulators:checkAccess'],
35+
['callable' => 'menu.default_tree_manipulators:generateIndexAndSort'],
36+
];
3737
$tree = $menu_tree->transform($tree, $manipulators);
3838

3939
$output['#theme'] = 'accordian_menus_block';
4040
$output['#attached']['library'][] = 'accordion_menus/accordion_menus_widget';
41-
41+
4242
foreach ($tree as $key => $menu_item) {
4343
if ($menu_item->hasChildren) {
4444
$elements[$key] = [
4545
'content' => $this->generateSubMenuTree($menu_item->subtree),
46-
'title' => $menu_item->link->getTitle()
46+
'title' => $menu_item->link->getTitle(),
4747
];
4848
}
4949
}
@@ -52,11 +52,14 @@ public function build() {
5252
return $output;
5353
}
5454

55+
/**
56+
* Generate submenu output.
57+
*/
5558
private function generateSubMenuTree($menu) {
5659
$output = [];
5760
$item_lists = [];
58-
foreach($menu as $item) {
59-
//If menu element disabled skip this branch
61+
foreach ($menu as $item) {
62+
// If menu element disabled skip this branch.
6063
if ($item->link->isEnabled()) {
6164
$item_lists[] = Link::fromTextAndUrl($item->link->getTitle(), $item->link->getUrlObject());
6265
}

src/Plugin/Derivative/AccordionMenusBlock.php

+2-7
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,5 @@
11
<?php
22

3-
/**
4-
* @file
5-
* Contains \Drupal\accordion_menus\Plugin\Derivative\AccordionMenusBlock.
6-
*/
7-
83
namespace Drupal\accordion_menus\Plugin\Derivative;
94

105
use Drupal\Component\Plugin\Derivative\DeriverBase;
@@ -52,9 +47,9 @@ public function getDerivativeDefinitions($base_plugin_definition) {
5247
// Get menus from accordion configuration.
5348
$accordion_menus = \Drupal::config('accordion_menus.settings')->get('accordion_menus');
5449
foreach ($this->menuStorage->loadMultiple() as $menu => $entity) {
55-
if (in_array($menu, $accordion_menus, true)) {
50+
if (in_array($menu, $accordion_menus, TRUE)) {
5651
$this->derivatives[$menu] = $base_plugin_definition;
57-
$this->derivatives[$menu]['admin_label'] = t('Accordion ') . $entity->label();
52+
$this->derivatives[$menu]['admin_label'] = t('Accordion') . ' ' . $entity->label();
5853
$this->derivatives[$menu]['config_dependencies']['config'] = [$entity->getConfigDependencyName()];
5954
}
6055
}

0 commit comments

Comments
 (0)