Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign app for Windows #34

Open
cheshire137 opened this issue Aug 25, 2018 · 2 comments
Open

Sign app for Windows #34

cheshire137 opened this issue Aug 25, 2018 · 2 comments
Labels
Windows

Comments

@cheshire137
Copy link
Owner

Downloading the latest release and running it on Windows results in a "Windows SmartScreen prevented an unrecognized app from starting" message in Windows 10. You can choose "Run anyway" but it looks scary. Maybe use https://github.com/unindented/electron-installer-windows?
cheshire137 added a commit that referenced this issue Aug 25, 2018
@cheshire137
Start on a command to build a Windows installer
6b1b1cd 
Part of #34. Fails currently with a NuGet error:

> Invalid URI: The format of the URI could not be determined.

Think it's due to not having an icon #21
@cheshire137
Copy link
Owner Author

Even using --asar in the electron-build-windows script, the resulting exe when downloaded prompts the Windows SmartScreen modal. So I think electron-installer-windows will still be necessary.

@cheshire137
Copy link
Owner Author

https://www.christianengvall.se/electron-windows-installer/ uses https://github.com/electron/windows-installer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cheshire137