Skip to content

Commit fb55588

Browse files
author
Tanner Davis
authored
Dart pub warning fixes (#19)
* Version bump prep * Update pubspec.yaml * Warning fixes from dart pub
1 parent 0edb0ae commit fb55588

3 files changed

Lines changed: 1 addition & 15 deletions

File tree

lib/card_number.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,6 @@ import 'validation_results.dart';
1010
/// Validates the credit card number and determines
1111
/// the credit card type as well
1212
13-
/// The default card number length. Set to 19
14-
const int _DEFAULT_MAX_CARD_NUM_LENGTH = 19;
15-
1613
/// Default string returned on a failed validation
1714
const String _DEFAULT_FAIL_MESSAGE = 'Invalid credit card number';
1815

lib/postal_code.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import 'validation_results.dart';
77
/// service like Stripe or Braintree for that.
88
99
/// The default minimum postal code string length. Set to 3
10-
const int _DEFAULT_MIN_POSTAL_CODE_LENGTH = 3;
10+
// const int _DEFAULT_MIN_POSTAL_CODE_LENGTH = 3;
1111

1212
/// Checks if the postal code seems legit
1313
ValidationResults validatePostalCode(String postalCode, {int? minLength}) {

test/card_number_test.dart

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -44,17 +44,6 @@ void main() {
4444
SecurityCode.cvv(),
4545
);
4646

47-
// Conflicts with typical Visa card
48-
final CreditCardType conflictingCardType = CreditCardType(
49-
'conflict',
50-
'Conflict',
51-
[16], // only length 16
52-
{
53-
Pattern(['4'])
54-
},
55-
SecurityCode.cvv(),
56-
);
57-
5847
final String someMadeUpCCNumFull = "9999 6614 3472 7891";
5948
final String someMadeUpCCNumPartial = "9999 6614 3472";
6049
final String modifiedVisaCCNumFull = "3538243039991295";

0 commit comments

Comments
 (0)