Skip to content

Commit d365860

Browse files
committed
Clean up method to close model: don't trigger events in the view
1 parent 7eb945c commit d365860

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

web/app/models/item.coffee

+3
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,8 @@ module.exports = class Item extends Backbone.Model
33

44
initialize: ->
55

6+
close: () =>
7+
@trigger "closed", @
8+
69

710

web/app/views/items/item.coffee

+3-4
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,10 @@ module.exports = class ItemView extends Backbone.View
77
@template = require "templates/items/show"
88

99
events: =>
10-
"click .close": "closeEvent"
10+
"click .close": "closeModel"
1111

12-
closeEvent: =>
13-
# Remove from collection here
14-
@model.trigger "closed", @model
12+
closeModel: =>
13+
@model.close()
1514

1615
render: ->
1716
@$el.html @template

web/app/views/items/item_collection.coffee

+3-4
Original file line numberDiff line numberDiff line change
@@ -22,16 +22,15 @@ module.exports = class ItemCollectionView extends Backbone.View
2222
if e.keyCode == 13 # On Enter
2323
@addNewItem()
2424

25-
modClosed: (mod) =>
26-
@collection.remove mod
27-
2825
render: =>
2926
@$el.html @template
3027

3128
item_container = @$el.find(".items_list")
3229

3330
for model in @collection.models
34-
model.on "closed", @modClosed
31+
model.on "closed", () =>
32+
@collection.remove(model)
33+
3534

3635
item_view = new ItemView
3736
model: model

0 commit comments

Comments
 (0)