From ea917505c462e4053f73f474c63e5bebebf5388d Mon Sep 17 00:00:00 2001 From: Chris Bobbe Date: Thu, 13 Jun 2024 21:54:53 -0700 Subject: [PATCH] msglist: Tweak app-bar title to look better after recent text-size change In a recent commit in this series, we decreased the app-bar title text size, to align with the new Figma. The spacing and alignment in MessageListAppBarTitle for stream and topic narrows looked a little off after doing that. This should make it look better. I'm leaving the comment saying it's "a bit ad hoc", though; this will remain true until we have a Figma design to follow. --- lib/widgets/message_list.dart | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/widgets/message_list.dart b/lib/widgets/message_list.dart index c130169cd5..b0783202a1 100644 --- a/lib/widgets/message_list.dart +++ b/lib/widgets/message_list.dart @@ -131,11 +131,10 @@ class MessageListAppBarTitle extends StatelessWidget { // TODO(design): The vertical alignment of the stream privacy icon is a bit ad hoc. // For screenshots of some experiments, see: // https://github.com/zulip/zulip-flutter/pull/219#discussion_r1281024746 - crossAxisAlignment: CrossAxisAlignment.baseline, - textBaseline: localizedTextBaseline(context), + crossAxisAlignment: CrossAxisAlignment.center, children: [ Icon(size: 16, icon), - const SizedBox(width: 8), + const SizedBox(width: 4), Flexible(child: Text(text)), ]); }