Merge pull request GenFit#144 from GiacomoXT/main

TadeasB · web-flow · commit af3993d6f6bd · 2025-07-10T17:54:23.000+02:00
Require lastPval &gt;= minPval_ in order to mimic older behaviour of DAF
diff --git a/fitters/src/DAF.cc b/fitters/src/DAF.cc
@@ -151,7 +151,7 @@ void DAF::processTrackWithRep(Track* tr, const AbsTrackRep* rep, bool resortHits
     try{
       converged = calcWeights(tr, rep, betas_.at(iBeta));
       if (!converged && iBeta >= static_cast<unsigned int>(minIterForPval_ - 1) &&
-          status->getBackwardPVal() > minPval_ && lastPval > minPval_ && fabs(lastPval - status->getBackwardPVal()) < this->deltaPval_) {
+          status->getBackwardPVal() > minPval_ && lastPval >= minPval_ && fabs(lastPval - status->getBackwardPVal()) < this->deltaPval_) {
         if (debugLvl_ > 0) {
           debugOut << "converged by Pval = " << status->getBackwardPVal() << " even though weights changed at iBeta = " << iBeta << std::endl;
         }

Original file line number	Diff line number	Diff line change
`@@ -151,7 +151,7 @@ void DAF::processTrackWithRep(Track* tr, const AbsTrackRep* rep, bool resortHits`
`151`	`151`	`try{`
`152`	`152`	`converged = calcWeights(tr, rep, betas_.at(iBeta));`
`153`	`153`	`if (!converged && iBeta >= static_cast<unsigned int>(minIterForPval_ - 1) &&`
`154`		`- status->getBackwardPVal() > minPval_ && lastPval > minPval_ && fabs(lastPval - status->getBackwardPVal()) < this->deltaPval_) {`
	`154`	`+ status->getBackwardPVal() > minPval_ && lastPval >= minPval_ && fabs(lastPval - status->getBackwardPVal()) < this->deltaPval_) {`
`155`	`155`	`if (debugLvl_ > 0) {`
`156`	`156`	`debugOut << "converged by Pval = " << status->getBackwardPVal() << " even though weights changed at iBeta = " << iBeta << std::endl;`
`157`	`157`	`}`