[BUG] explicitly allow extra params (#6534)

pydantic's default behavior should be to ignore extra params. In
practice, we see it error if extra params are provided

https://docs.pydantic.dev/latest/concepts/models/#extra-data

This explicitly sets the "extra" param

Author: kylediaz

chromadb/config.py

@@ -317,7 +317,7 @@ def __getitem__(self, key: str) -> Any:
             raise ValueError(LEGACY_ERROR)
         return val
 
-    model_config = {"env_file": ".env", "env_file_encoding": "utf-8"}
+    model_config = {"env_file": ".env", "env_file_encoding": "utf-8", "extra": "ignore"}
 
 
 T = TypeVar("T", bound="Component")

chromadb/test/test_config.py

@@ -1,6 +1,9 @@
 from chromadb.config import Component, System, Settings
 from overrides import overrides
 from threading import local
+from unittest.mock import patch
+import pytest
+import os
 import random
 
 data = local()  # use thread local just in case tests ever run in parallel
@@ -207,3 +210,25 @@ def test_http_client_setting_overrides() -> None:
     assert settings.chroma_http_keepalive_secs == 5.5
     assert settings.chroma_http_max_connections == 123
     assert settings.chroma_http_max_keepalive_connections == 17
+
+
+@patch.dict(os.environ, {"CHROMA_API_IMPL": "my_api_impl"}, clear=True)
+def test_uses_env() -> None:
+    settings = Settings()
+    assert settings.chroma_api_impl == "my_api_impl"
+
+
+@patch.dict(os.environ, {"MY_ENV_VAR": "my_env_var"}, clear=True)
+def test_ignores_extra_env_vars() -> None:
+    settings = Settings()
+    with pytest.raises(AttributeError):
+        _ = settings.my_env_var
+
+
+def test_local_ignores_extra_settings_param() -> None:
+    settings = Settings(extra_param="asdsdsds", tenant_id="test")
+    # does not error if the extra param is present in the settings object
+    assert settings.tenant_id == "test"
+    # but it should error if the extra param is accessed
+    with pytest.raises(AttributeError):
+        _ = settings.extra_param