PHP 8.4 support (#21)

* PHP 8.4 support

* Update CHANGELOG.md

* Fixes

Author: GrahamCampbell

.github/workflows/tests.yml

@@ -11,7 +11,7 @@ jobs:
 
     strategy:
       matrix:
-        php: ['7.4', '8.0', '8.1', '8.2', '8.3']
+        php: ['7.4', '8.0', '8.1', '8.2', '8.3', '8.4']
 
     steps:
       - name: Checkout Code

CHANGELOG.md

@@ -1,6 +1,12 @@
 # CHANGELOG
 
 
+## 1.7.0 (UPCOMING)
+
+* Add `Client::getSocketResource` method
+* Add support for PHP 8.4
+
+
 ## 1.6.0 (2024-03-17)
 
 * Add support for PHP 8.3

phpunit.xml.dist

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" backupGlobals="false" beStrictAboutOutputDuringTests="true" beStrictAboutTestsThatDoNotTestAnything="true" bootstrap="vendor/autoload.php" colors="true" processIsolation="false" stopOnFailure="false" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.0/phpunit.xsd">
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" backupGlobals="false" beStrictAboutOutputDuringTests="true" beStrictAboutTestsThatDoNotTestAnything="true" bootstrap="vendor/autoload.php" colors="true" displayDetailsOnTestsThatTriggerDeprecations="true" processIsolation="false" stopOnFailure="false" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.0/phpunit.xsd">
   <testsuites>
     <testsuite name="Test Suite">
       <directory suffix="Test.php">./tests</directory>

src/Connection.php

@@ -246,7 +246,7 @@ public function getClientApplication()
      *
      * @return bool
      */
-    public function close(int $code = Protocol::CLOSE_NORMAL, string $reason = null): bool
+    public function close(int $code = Protocol::CLOSE_NORMAL, ?string $reason = null): bool
     {
         try {
             if (!$this->handshaked) {

src/Exception/BadRequestException.php

@@ -7,7 +7,7 @@
 
 class BadRequestException extends HandshakeException
 {
-    public function __construct(string $message = '', int $code = null, Throwable $previous = null)
+    public function __construct(string $message = '', ?int $code = null, ?Throwable $previous = null)
     {
         parent::__construct($message, $code ?? Protocol::HTTP_BAD_REQUEST, $previous);
     }

src/Exception/CloseException.php

@@ -11,7 +11,7 @@
  */
 class CloseException extends WrenchException
 {
-    public function __construct(string $message = '', int $code = null, Throwable $previous = null)
+    public function __construct(string $message = '', ?int $code = null, ?Throwable $previous = null)
     {
         parent::__construct($message, $code ?? Protocol::CLOSE_UNEXPECTED, $previous);
     }

src/Exception/HandshakeException.php

@@ -8,7 +8,7 @@
 
 class HandshakeException extends WrenchException
 {
-    public function __construct(string $message = '', int $code = null, Throwable $previous = null)
+    public function __construct(string $message = '', ?int $code = null, ?Throwable $previous = null)
     {
         parent::__construct($message, $code ?? Protocol::HTTP_SERVER_ERROR, $previous);
     }

src/Exception/InvalidOriginException.php

@@ -10,7 +10,7 @@
  */
 class InvalidOriginException extends HandshakeException
 {
-    public function __construct(string $message = '', int $code = null, Throwable $previous = null)
+    public function __construct(string $message = '', ?int $code = null, ?Throwable $previous = null)
     {
         parent::__construct($message, $code ?? Protocol::HTTP_FORBIDDEN, $previous);
     }

tests/Util/SslTest.php

@@ -6,6 +6,8 @@
 
 class SslTest extends BaseTest
 {
+    private $tmp;
+
     public function setUp(): void
     {
         parent::setUp();