Convert with_month and with_day to return Result
#1509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 0.5.x #1509 +/- ##
==========================================
- Coverage 94.03% 94.02% -0.02%
==========================================
Files 37 37
Lines 17005 16974 -31
==========================================
- Hits 15991 15960 -31
Misses 1014 1014 ☔ View full report in Codecov by Sentry. |
pitdicker
commented
Mar 11, 2024
djc
approved these changes
Mar 12, 2024
Collaborator
Author
|
Quick work! I'm still opening my PC 😆 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert
NaiveDate::{with_month, with_month0, with_day, with_day0}andNaiveDateTime::{with_month, with_month0, with_day, with_day0}.All make use of
NaiveDate::with_mdfinternally.Based on #1466, I'll rebase once that is merged.
cc @Zomtir