Fix active_record_doctor references warning

Author: rostikkkk2

Gemfile

@@ -25,7 +25,7 @@ gem 'sass-rails', '~> 5.0'
 gem 'uglifier', '>= 1.3.0'
 # See https://github.com/rails/execjs#readme for more supported runtimes
 # gem 'mini_racer', platforms: :ruby
-gem 'active_record_doctor', '1.7.0'
+
 # Use CoffeeScript for .coffee assets and views
 gem 'coffee-rails', '~> 4.2'
 # Turbolinks makes navigating your web application faster. Read more: https://github.com/turbolinks/turbolinks

lib/inquisition/active_record_doctor/runner.rb

@@ -11,20 +11,21 @@ module Inquisition
   module ActiveRecordDoctor
     class Runner < ::Inquisition::Runner
       TASKS = {
-        # ::ActiveRecordDoctor::Tasks::ExtraneousIndexes => Category::PERFORMANCE,
-        # ::ActiveRecordDoctor::Tasks::MissingForeignKeys => Category::BUG_RISK,
-        # ::ActiveRecordDoctor::Tasks::MissingNonNullConstraint => Category::BUG_RISK,
-        # ::ActiveRecordDoctor::Tasks::MissingPresenceValidation => Category::BUG_RISK,
-        # ::ActiveRecordDoctor::Tasks::MissingUniqueIndexes => Category::BUG_RISK,
+        ::ActiveRecordDoctor::Tasks::ExtraneousIndexes => Category::PERFORMANCE,
+        ::ActiveRecordDoctor::Tasks::MissingForeignKeys => Category::BUG_RISK,
+        ::ActiveRecordDoctor::Tasks::MissingNonNullConstraint => Category::BUG_RISK,
+        ::ActiveRecordDoctor::Tasks::MissingPresenceValidation => Category::BUG_RISK,
+        ::ActiveRecordDoctor::Tasks::MissingUniqueIndexes => Category::BUG_RISK,
         ::ActiveRecordDoctor::Tasks::UndefinedTableReferences => Category::UNUSED_CODE,
-        # ::ActiveRecordDoctor::Tasks::UnindexedDeletedAt => Category::PERFORMANCE,
-        # ::ActiveRecordDoctor::Tasks::UnindexedForeignKeys => Category::PERFORMANCE
+        ::ActiveRecordDoctor::Tasks::UnindexedDeletedAt => Category::PERFORMANCE,
+        ::ActiveRecordDoctor::Tasks::UnindexedForeignKeys => Category::PERFORMANCE
       }.freeze
 
       def call
         TASKS.keys.each do |ard_task|
           ard_task.run.first.each do |table, column|
-            binding.pry
+            next unless table && column
+
             @issues << Inquisition::Issue.new(Issue.new(ard_task, table, column).to_h.merge(runner: self))
           end
         end

spec/fixtures/files/active_record_doctor.yml

@@ -1,27 +1,21 @@
-# - severity: :low
-#   category: :bug_risk
-#   message: 'active_storage_attachments has missing foreign keys, details: blob_id'
-# - severity: :low
-#   category: :bug_risk
-#   message: 'projects has missing foreign keys, details: user_id'
-# - severity: :low
-#   category: :bug_risk
-#   message: 'projects has missing non null constraint, details: name, user_id'
-# - severity: :low
-#   category: :bug_risk
-#   message: 'ActiveStorage::Attachment has missing presence validation, details: name, record_type'
-# - severity: :low
-#   category: :bug_risk
-#   message: 'ActiveStorage::Blob has missing presence validation, details: key, filename, byte_size, checksum'
 - severity: :low
-  category: :unused_code
-  message: ' has undefined table references, details: n/a'
+  category: :bug_risk
+  message: 'active_storage_attachments has missing foreign keys, details: blob_id'
 - severity: :low
-  category: :unused_code
-  message: 'true has undefined table references, details: n/a'
-# - severity: :low
-#   category: :performance
-#   message: 'active_storage_attachments has unindexed foreign keys, details: record_id'
-# - severity: :low
-#   category: :performance
-#   message: 'projects has unindexed foreign keys, details: user_id'
+  category: :bug_risk
+  message: 'projects has missing foreign keys, details: user_id'
+- severity: :low
+  category: :bug_risk
+  message: 'projects has missing non null constraint, details: name, user_id'
+- severity: :low
+  category: :bug_risk
+  message: 'ActiveStorage::Attachment has missing presence validation, details: name, record_type'
+- severity: :low
+  category: :bug_risk
+  message: 'ActiveStorage::Blob has missing presence validation, details: key, filename, byte_size, checksum'
+- severity: :low
+  category: :performance
+  message: 'active_storage_attachments has unindexed foreign keys, details: record_id'
+- severity: :low
+  category: :performance
+  message: 'projects has unindexed foreign keys, details: user_id'