Poor man mimic of NumberFormat class

Author: chukShirley

composer.json

@@ -24,7 +24,8 @@
   },
   "autoload-dev": {
     "psr-4": {
-      "NoIntlIntegrationTest\\": "tests/integration"
+      "NoIntlIntegrationTest\\": "tests/integration",
+      "NoIntlUnitTest\\": "tests/unit"
     }
   }
 }

phpunit.xml

@@ -15,5 +15,8 @@
         <testsuite name="IntegrationTests">
             <directory>./tests/integration</directory>
         </testsuite>
+        <testsuite name="UnitTests">
+            <directory>./tests/unit</directory>
+        </testsuite>
     </testsuites>
 </phpunit>

src/TranslatorFactory.php src/Factory/Translator/TranslatorFactory.php

@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace NoIntl;
+namespace NoIntl\Factory\Translator;
 
 use Interop\Container\ContainerInterface;
 use Zend\I18n\Translator\Translator;

src/CurrencyFormatFactory.php src/Factory/View/Helper/CurrencyFormatFactory.php

@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace NoIntl;
+namespace NoIntl\Factory\View\Helper;
 
 use Interop\Container\ContainerInterface;
 use NoIntl\View\Helper\CurrencyFormat;

src/Factory/View/Helper/NumberFormatFactory.php

@@ -0,0 +1,41 @@
+<?php
+
+declare(strict_types=1);
+
+namespace NoIntl\Factory\View\Helper;
+
+use Interop\Container\ContainerInterface;
+use NoIntl\View\Helper\NumberFormat;
+use Zend\ServiceManager\Factory\FactoryInterface;
+
+final class NumberFormatFactory implements FactoryInterface
+{
+    /**
+     * @param ContainerInterface $container
+     * @param string $requestedName
+     * @param array|null $options
+     * @return NumberFormat|object
+     */
+    public function __invoke(ContainerInterface $container, $requestedName, array $options = null)
+    {
+        $helper = new NumberFormat();
+        $helper->setLocale(
+            $this->getLocale($container)
+        );
+
+        return $helper;
+    }
+
+    /**
+     * @param ContainerInterface $container
+     * @return string
+     */
+    private function getLocale(ContainerInterface $container): string
+    {
+        $config = $container->get('config');
+        if (!isset($config['no_intl']['default_locale'])) {
+            return self::DEFAULT_LOCALE;
+        }
+        return $config['no_intl']['default_locale'];
+    }
+}

src/Module.php

@@ -4,8 +4,12 @@
 
 namespace NoIntl;
 
+use NoIntl\Factory\Translator\TranslatorFactory;
+use NoIntl\Factory\View\Helper\CurrencyFormatFactory;
+use NoIntl\Factory\View\Helper\NumberFormatFactory;
 use Zend\I18n\Translator\TranslatorInterface;
 use Zend\I18n\View\Helper\CurrencyFormat;
+use Zend\I18n\View\Helper\NumberFormat;
 use Zend\ModuleManager\Feature\ConfigProviderInterface;
 
 final class Module implements ConfigProviderInterface
@@ -20,6 +24,7 @@ public function getConfig(): array
                 'factories' => [
                     TranslatorInterface::class => TranslatorFactory::class,
                     CurrencyFormat::class => CurrencyFormatFactory::class,
+                    NumberFormat::class => NumberFormatFactory::class,
                 ],
             ],
         ];

src/View/Helper/NumberFormat.php

@@ -0,0 +1,34 @@
+<?php
+
+declare(strict_types=1);
+
+namespace NoIntl\View\Helper;
+
+final class NumberFormat extends \Zend\I18n\View\Helper\NumberFormat
+{
+    public function __construct()
+    {
+    }
+
+    /**
+     * Format a number
+     *
+     * @param  int|float   $number
+     * @param  int|null    $formatStyle
+     * @param  int|null    $formatType
+     * @param  string|null $locale
+     * @param  int|null    $decimals
+     * @param  array|null  $textAttributes
+     * @return string
+     */
+    public function __invoke(
+        $number,
+        $formatStyle = null,
+        $formatType = null,
+        $locale = null,
+        $decimals = null,
+        array $textAttributes = null
+    ) {
+        return number_format((int)$number, $decimals);
+    }
+}

tests/integration/TranslatorFactoryTest.php tests/integration/Factory/Translator/TranslatorFactoryTest.php

@@ -2,9 +2,9 @@
 
 declare(strict_types=1);
 
-namespace NoIntlIntegrationTest;
+namespace NoIntlIntegrationTest\Factory\Translator;
 
-use NoIntl\TranslatorFactory;
+use NoIntl\Factory\Translator\TranslatorFactory;
 use PHPUnit\Framework\TestCase;
 use Zend\I18n\Translator\Translator;
 use Zend\ServiceManager\ServiceManager;

tests/integration/CurrencyFormatFactoryTest.php tests/integration/Factory/View/Helper/CurrencyFormatFactoryTest.php

@@ -2,10 +2,11 @@
 
 declare(strict_types=1);
 
-namespace NoIntlIntegrationTest;
+namespace NoIntlIntegrationTest\Factory\View\Helper;
 
 use Interop\Container\ContainerInterface;
-use NoIntl\CurrencyFormatFactory;
+use NoIntl\Factory\View\Helper\CurrencyFormatFactory;
+use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 use Zend\I18n\View\Helper\CurrencyFormat;
 
@@ -15,6 +16,7 @@ final class CurrencyFormatFactoryTest extends TestCase
 
     public function testCanOverrideCurrencyFormatIntlExtensionRequirement()
     {
+        /** @var ContainerInterface|MockObject $container */
         $container = $this->createMock(ContainerInterface::class);
         $container->expects($this->once())->method('get')->with('config')->willReturn([
             'no_intl' => [

tests/integration/Factory/View/Helper/NumberFormatFactoryTest.php

@@ -0,0 +1,18 @@
+<?php
+
+declare(strict_types=1);
+
+namespace NoIntlIntegrationTest\Factory\View\Helper;
+
+use NoIntl\View\Helper\NumberFormat;
+use PHPUnit\Framework\TestCase;
+
+final class NumberFormatFactoryTest extends TestCase
+{
+    public function testCanMimicIntlExtensionBehavior()
+    {
+        $helper = new NumberFormat();
+        $actual = $helper->__invoke(12, null, null, 'en_US', 4);
+        $this->assertEquals('12.0000', $actual);
+    }
+}