Allow periodicFunc to execute "now" (openbao#1129)

* Small mainline code change for flakey test -- allow periodicFunc to
fire if it is exactly the time to run

Signed-off-by: Geoff Wilson <[email protected]>

* Add changelog

Signed-off-by: Geoff Wilson <[email protected]>

---------

Signed-off-by: Geoff Wilson <[email protected]>

Author: suprjinx

changelog/1129.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+vault: addresses a timing issue revealed in OIDC_PeriodicFunc test
+```

vault/identity_store_oidc.go

@@ -2000,7 +2000,7 @@ func (i *IdentityStore) oidcPeriodicFunc(ctx context.Context) {
 	// be run at any time safely, but there is no need to invoke them (which
 	// might be somewhat expensive if there are many roles/keys) if we're not
 	// past any rotation/expiration TTLs.
-	if now.After(nextRun) {
+	if now.Equal(nextRun) || now.After(nextRun) {
 		// Initialize to a fairly distant next run time. This will be brought in
 		// based on key rotation times.
 		nextRun = now.Add(24 * time.Hour)

vault/identity_store_oidc_test.go

@@ -1137,7 +1137,7 @@ func TestOIDC_PeriodicFunc(t *testing.T) {
 			i := 0
 			for currentCycle <= lastCycle {
 				// sleep for a rotation period
-				time.Sleep(testSet.namedKey.RotationPeriod + (10 * time.Millisecond))
+				time.Sleep(testSet.namedKey.RotationPeriod)
 				c.identityStore.oidcPeriodicFunc(ctx)
 				if currentCycle == testSet.testCases[i].cycle {
 					namedKeyEntry, _ := storage.Get(ctx, namedKeyConfigPath+testSet.namedKey.name)