Skip to content

Commit 53e0a1a

Browse files
committed
fix SD position logic to account for settings.toml. Fix update pre-commit hooks to newer versions and fix issues flagged by new versions.
1 parent a967817 commit 53e0a1a

File tree

5 files changed

+24
-15
lines changed

5 files changed

+24
-15
lines changed

.gitignore

+12
Original file line numberDiff line numberDiff line change
@@ -6,3 +6,15 @@ __pycache__
66
latest_bundle_data.json
77
latest_bundle_tag.json
88
generated_images
9+
10+
# Virtual environment-specific files
11+
.env
12+
.venv
13+
14+
# MacOS-specific files
15+
*.DS_Store
16+
17+
# IDE-specific files
18+
.idea
19+
.vscode
20+
*~

.pre-commit-config.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ repos:
88
hooks:
99
- id: black
1010
- repo: https://github.com/fsfe/reuse-tool
11-
rev: v0.12.1
11+
rev: v1.1.2
1212
hooks:
1313
- id: reuse
1414
- repo: https://github.com/pre-commit/pre-commit-hooks
@@ -18,7 +18,7 @@ repos:
1818
- id: end-of-file-fixer
1919
- id: trailing-whitespace
2020
- repo: https://github.com/pycqa/pylint
21-
rev: pylint-2.7.1
21+
rev: v3.2.7
2222
hooks:
2323
- id: pylint
2424
name: pylint (library code)

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,4 +30,4 @@ The help command will list all possible commands and arguments.
3030

3131
```shell
3232
python3 create_requirement_images.py --help
33-
```
33+
```

create_requirement_images.py

+5-8
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,8 @@
3838
TEXT_COLOR = "#B0B0B0"
3939
HIDDEN_TEXT_COLOR = "#808080"
4040

41-
f = open("latest_bundle_data.json", "r")
42-
bundle_data = json.load(f)
43-
f.close()
41+
with open("latest_bundle_data.json", "r", encoding="utf-8") as f:
42+
bundle_data = json.load(f)
4443

4544

4645
def asset_path(asset_name):
@@ -416,17 +415,15 @@ def make_sd_dir(position):
416415
)
417416
make_libraries(final_list_to_render, _libraries_position)
418417

419-
if project_files_count == 0:
420-
project_files_count = 1
421-
422418
_sd_dir_position = (
423419
76,
424420
PADDING
425-
+ (LINE_SPACING * (7 + project_files_count + len(final_list_to_render))),
421+
+ (LINE_SPACING * (7 + project_files_count + len(final_list_to_render)))
422+
+ (1 if context["added_settings_toml"] else 0) * LINE_SPACING,
426423
)
427424
make_sd_dir(_sd_dir_position)
428425

429-
img.save("generated_images/{}.png".format(image_name))
426+
img.save(f"generated_images/{image_name}.png")
430427

431428

432429
def generate_learn_requirement_image( # pylint: disable=invalid-name

get_imports.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -116,14 +116,14 @@ def ensure_latest_bundle():
116116

117117
ensure_latest_bundle()
118118

119-
with open("latest_bundle_data.json", "r") as f:
119+
with open("latest_bundle_data.json", "r", encoding="utf-8") as f:
120120
bundle_data = json.load(f)
121121

122122

123123
def get_files_for_project(project_name):
124124
"""Get the set of files for a learn project"""
125125
found_files = set()
126-
project_dir = "{}/{}/".format(LEARN_GUIDE_REPO, project_name)
126+
project_dir = f"{LEARN_GUIDE_REPO}/{project_name}/"
127127

128128
full_tree = os.walk(project_dir)
129129
root_level = next(full_tree)
@@ -153,11 +153,11 @@ def get_libs_for_project(project_name):
153153
"""Get the set of libraries for a learn project"""
154154
found_libs = set()
155155
found_imports = []
156-
project_dir = "{}{}/".format(LEARN_GUIDE_REPO, project_name)
156+
project_dir = f"{LEARN_GUIDE_REPO}{project_name}/"
157157
for file in os.listdir(project_dir):
158158
if file.endswith(".py"):
159159

160-
found_imports = findimports.find_imports("{}{}".format(project_dir, file))
160+
found_imports = findimports.find_imports(f"{project_dir}{file}")
161161

162162
for cur_import in found_imports:
163163
cur_lib = cur_import.name.split(".")[0]

0 commit comments

Comments
 (0)