lint: @typescript-eslint

cirosantilli · cirosantilli · commit f32c3bcaad91 · 2022-04-06T14:34:36.000+01:00
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -1,12 +1,21 @@
 {
-  "extends": ["eslint:recommended", "next", "prettier"],
+  "extends": [
+    "eslint:recommended",
+    "plugin:@typescript-eslint/eslint-recommended",
+    "plugin:@typescript-eslint/recommended",
+    "next",
+    "prettier"
+  ],
   "env": {
     "es6": true,
     "mocha": true
   },
   "plugins": ["prettier"],
   "rules": {
     "@next/next/no-img-element": "off",
+    "@typescript-eslint/no-explicit-any": "off",
+    "@typescript-eslint/no-extra-semi": "off",
+    "@typescript-eslint/no-var-requires": "off",
     "import/no-anonymous-default-export": "off",
     "prettier/prettier": "error"
   }
diff --git a/back/ProfilePage.ts b/back/ProfilePage.ts
@@ -28,7 +28,7 @@ export const getStaticPathsProfile: GetStaticPaths = async () => {
 
 export function getStaticPropsProfile(tab): GetStaticProps {
   return async ({ params: { pid } }) => {
-    let include = []
+    const include = []
     if (tab === 'my-posts') {
       include.push({
         model: sequelize.models.User,
diff --git a/front.ts b/front.ts
@@ -16,7 +16,7 @@ export function setCookie(name, value, days?: number, path = '/') {
 }
 
 export function setCookies(cookieDict, days?: number, path = '/') {
-  for (let key in cookieDict) {
+  for (const key in cookieDict) {
     setCookie(key, cookieDict[key], days, path)
   }
 }
diff --git a/front/ArticleEditor.tsx b/front/ArticleEditor.tsx
@@ -40,7 +40,7 @@ function editorReducer(state, action) {
   }
 }
 
-export default function ArticleEditorHoc(isnew: boolean = false) {
+export default function ArticleEditorHoc(isnew = false) {
   return function ArticleEditor({ article: initialArticle }) {
     let initialState
     if (initialArticle) {
diff --git a/front/ArticleList.tsx b/front/ArticleList.tsx
@@ -26,10 +26,10 @@ const ArticleList = ({
   const { pid } = query
   // The page can be seen up to date from SSR without refetching,
   // so we skip the fetch.
-  let ssrSkipFetch =
+  const ssrSkipFetch =
     page === 0 &&
     ((loggedInUser && what === 'feed') || (!loggedInUser && what === 'global'))
-  let fetchURL = (() => {
+  const fetchURL = (() => {
     if (loggedInUser === undefined || (ssr && ssrSkipFetch)) {
       // This makes SWR not fetch.
       return null
diff --git a/front/useLoggedInUser.ts b/front/useLoggedInUser.ts
@@ -1,12 +1,10 @@
 import useSWR from 'swr'
-import React from 'react'
 
 import { AUTH_COOKIE_NAME, AUTH_LOCAL_STORAGE_NAME, getCookie } from 'front'
 import checkLogin from 'front/checkLogin'
 import storage from 'front/localStorageHelper'
 
 export default function useLoggedInUser() {
-  React.useEffect(() => {})
   const { data: authCookie } = useSWR('auth/cookie', () => {
     const ret = getCookie(AUTH_COOKIE_NAME)
     if (!ret) {
diff --git a/pages/_app.tsx b/pages/_app.tsx
@@ -29,7 +29,7 @@ import 'style.scss'
 
 function MyHead() {
   const { title } = React.useContext(AppContext)
-  let realTitle = title === undefined ? '' : title + ' - '
+  const realTitle = title === undefined ? '' : title + ' - '
   return (
     <Head>
       <meta

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ export function setCookie(name, value, days?: number, path = '/') {`
`16`	`16`	`}`
`17`	`17`
`18`	`18`	`export function setCookies(cookieDict, days?: number, path = '/') {`
`19`		`- for (let key in cookieDict) {`
	`19`	`+ for (const key in cookieDict) {`
`20`	`20`	`setCookie(key, cookieDict[key], days, path)`
`21`	`21`	`}`
`22`	`22`	`}`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ function editorReducer(state, action) {`
`40`	`40`	`}`
`41`	`41`	`}`
`42`	`42`
`43`		`-export default function ArticleEditorHoc(isnew: boolean = false) {`
	`43`	`+export default function ArticleEditorHoc(isnew = false) {`
`44`	`44`	`return function ArticleEditor({ article: initialArticle }) {`
`45`	`45`	`let initialState`
`46`	`46`	`if (initialArticle) {`