Proper article ISR without calling API every time #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

cirosantilli opened this issue Jan 2, 2022 · 0 comments

Owner

cirosantilli commented Jan 2, 2022 •

edited

Loading

Currently in order to allow the user to preview their edits immediately, our "ISR" just does a GET every time, which defeats the purpose of ISR.

This is blocked on: https://stackoverflow.com/questions/68062987/next-js-isr-incremental-static-regeneration-how-to-rebuild-or-update-a-spec some more rationale also at the end of: https://stackoverflow.com/questions/67787456/what-is-the-difference-between-fallback-false-vs-true-vs-blocking-of-getstaticpa/67787457#67787457

Until then, real websites should just do SSR. But looks promising that Next.js will fix it to make ISR usable not too far in the future.

Initial prototype until we noticed it wouldn't work at: https://github.com/cirosantilli/node-express-sequelize-nextjs-realworld-example-app/tree/preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment